Page MenuHomePhabricator

[cmake] Also pass CMAKE_ASM_COMPILER_ID to next stage when bootstrapping
ClosedPublic

Authored by hintonda on Jan 18 2018, 12:40 AM.

Details

Summary

If CMAKE_ASM_COMPILER is set, cmake assumes
CMAKE_ASM_COMPILER_ID was also set, and doesn't try to set it.

Without CMAKE_ASM_COMPILER_ID, cmake can't set
CMAKE_ASM_COMPILER_OPTIONS_TARGET either, which means
CMAKE_ASM_COMPILER_TARGET is ignored, causing cross compiling to fail,
i.e., --target=${CMAKE_ASM_COMPILER_TARGET} isn't passed.

Diff Detail

Repository
rL LLVM

Event Timeline

hintonda created this revision.Jan 18 2018, 12:40 AM
compnerd accepted this revision.Jan 19 2018, 10:07 AM

Took a bit of reading to realize that the compiler is being set to clang, and therefore CMAKE_ASM_COMPILER_ID should be Clang.

This revision is now accepted and ready to land.Jan 19 2018, 10:07 AM

Took a bit of reading to realize that the compiler is being set to clang, and therefore CMAKE_ASM_COMPILER_ID should be Clang.

Thanks, I'll add that to the commit message.

This revision was automatically updated to reflect the committed changes.