This is an archive of the discontinued LLVM Phabricator instance.

Differential D42126

[test] Actually check the common parts in CodeGen/ARM/global-merge-external.ll. NFC.
ClosedPublic

Authored by mstorsjo on Jan 16 2018, 12:50 PM.

Details

Reviewers
john.brawn
compnerd
Commits
rGf9b031a47d2b: Merging r322900 and r323307:
rGd96be854e5f2: [test] Actually check the common parts in CodeGen/ARM/global-merge-external.ll.
rL323337: Merging r322900 and r323307:
rL322900: [test] Actually check the common parts in CodeGen/ARM/global-merge-external.ll.
Summary

Previously, these parts weren't ever checked. The label patterns need to be adjusted to match successfully on macho.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Jan 16 2018, 12:50 PM
Herald added subscribers: kristof.beyls, javed.absar, aemerson. · View Herald TranscriptJan 16 2018, 12:50 PM
john.brawn accepted this revision.Jan 18 2018, 4:39 AM

LGTM.

This revision is now accepted and ready to land.Jan 18 2018, 4:39 AM
Closed by commit rL322900: [test] Actually check the common parts in CodeGen/ARM/global-merge-external.ll. (authored by mstorsjo). · Explain WhyJan 18 2018, 1:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
ARM/
14 lines

Diff 130485

llvm/trunk/test/CodeGen/ARM/global-merge-external.ll

; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge | FileCheck %s --check-prefix=CHECK-MERGE ; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge | FileCheck %s --check-prefixes=CHECK,CHECK-MERGE
; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge -global-merge-on-external=true | FileCheck %s --check-prefix=CHECK-MERGE ; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge -global-merge-on-external=true | FileCheck %s --check-prefixes=CHECK,CHECK-MERGE
; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge -global-merge-on-external=false | FileCheck %s --check-prefix=CHECK-NO-MERGE ; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge -global-merge-on-external=false | FileCheck %s --check-prefixes=CHECK,CHECK-NO-MERGE
; RUN: llc < %s -mtriple=arm-macho -arm-global-merge | FileCheck %s --check-prefix=CHECK-NO-MERGE ; RUN: llc < %s -mtriple=arm-macho -arm-global-merge | FileCheck %s --check-prefixes=CHECK,CHECK-NO-MERGE
; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge -relocation-model=pic | FileCheck %s --check-prefix=CHECK-NO-MERGE ; RUN: llc < %s -mtriple=arm-eabi -arm-global-merge -relocation-model=pic | FileCheck %s --check-prefixes=CHECK,CHECK-NO-MERGE
@x = global i32 0, align 4 @x = global i32 0, align 4
@y = global i32 0, align 4 @y = global i32 0, align 4
@z = global i32 0, align 4 @z = global i32 0, align 4
define void @f1(i32 %a1, i32 %a2) { define void @f1(i32 %a1, i32 %a2) {
;CHECK: f1: ;CHECK: f1:
;CHECK: ldr {{r[0-9]+}}, [[LABEL1:\.LCPI[0-9]+_[0-9]]] ;CHECK: ldr {{r[0-9]+}}, [[LABEL1:\.?LCPI[0-9]+_[0-9]]]
;CHECK: [[LABEL1]]: ;CHECK: [[LABEL1]]:
;CHECK-MERGE: .long .L_MergedGlobals ;CHECK-MERGE: .long .L_MergedGlobals
;CHECK-NO-MERGE: .long {{_?x}} ;CHECK-NO-MERGE: .long {{_?x}}
store i32 %a1, i32* @x, align 4 store i32 %a1, i32* @x, align 4
store i32 %a2, i32* @y, align 4 store i32 %a2, i32* @y, align 4
ret void ret void
} }
define void @g1(i32 %a1, i32 %a2) { define void @g1(i32 %a1, i32 %a2) {
;CHECK: g1: ;CHECK: g1:
;CHECK: ldr {{r[0-9]+}}, [[LABEL2:\.LCPI[0-9]+_[0-9]]] ;CHECK: ldr {{r[0-9]+}}, [[LABEL2:\.?LCPI[0-9]+_[0-9]]]
;CHECK: [[LABEL2]]: ;CHECK: [[LABEL2]]:
;CHECK-MERGE: .long .L_MergedGlobals ;CHECK-MERGE: .long .L_MergedGlobals
;CHECK-NO-MERGE: .long {{_?y}} ;CHECK-NO-MERGE: .long {{_?y}}
store i32 %a1, i32* @y, align 4 store i32 %a1, i32* @y, align 4
store i32 %a2, i32* @z, align 4 store i32 %a2, i32* @z, align 4
ret void ret void
} }
Show All 15 Lines