Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Rewrite debugger tuning test case to not depend on apple sections
ClosedPublic

Authored by labath on Jan 12 2018, 4:47 AM.

Details

Summary

In a follow-up commit I'd like to change the rules for emission of
accelerator tables, which means we won't be able to use them as a litmus
test for the debugger tuning options. Instead of sections, I base the
test on the presence/absence of some debug info attributes and opcodes:
LLDB - prefers DW_OP_form_tls_address and uses DW_AT_APPLE_optimized
GDB - prefers DW_OP_GNU_push_tls_address and does not use the optimized

attribute

SCE - prefers DW_OP_form_tls_address and does not use the optimized

attribute

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jan 12 2018, 4:47 AM
aprantl accepted this revision.Jan 12 2018, 8:45 AM

Seems fine.

This revision is now accepted and ready to land.Jan 12 2018, 8:45 AM
This revision was automatically updated to reflect the committed changes.