Page MenuHomePhabricator

[analyzer] Fix CXXNewExpr callback order.

Authored by NoQ on Jan 10 2018, 6:27 PM.



Even if we later change how these callbacks work (as in, i wanted to clean up the current mess so that it at least worked in any reasonable manner.

  1. Make the PreStmt<CXXNewExpr> callback actually work. It is called on CXXNewExpr pre-visit in ExprEngine.
  2. In -analyzer-config c++-allocator-inlining, don't call the PostStmt<CXXNewExpr> callback twice when the allocator is inlined.

Diff Detail

rC Clang

Event Timeline

NoQ created this revision.Jan 10 2018, 6:27 PM
NoQ added inline comments.Jan 10 2018, 6:28 PM

This ensures that there are no other callbacks after PostStmt<CXXNewExpr>, in particular that there's no another PostStmt<CXXNewExpr>.

dcoughlin accepted this revision.Jan 12 2018, 5:04 PM

Looks great. It is nice to have this fixed and cleaned up!


Style nit: use auto for the casts.

This revision is now accepted and ready to land.Jan 12 2018, 5:04 PM
This revision was automatically updated to reflect the committed changes.