This is an archive of the discontinued LLVM Phabricator instance.

[Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts
ClosedPublic

Authored by phosek on Jan 10 2018, 5:33 PM.

Reviewers

mcgrathr
jakehehrlich

Commits

Summary

llvm-objcopy already supports all the necessary functionality for ELF.

The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will also use llvm-objcopy.

In D41930#972923, @emaste wrote:

The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will also use llvm-objcopy.

That's a good point, updated.

This revision is now accepted and ready to land.Jan 10 2018, 8:03 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

cmake/

caches/

1 line

	Show All 11 Lines
	set(LLVM_ENABLE_ZLIB ON CACHE BOOL "")			set(LLVM_ENABLE_ZLIB ON CACHE BOOL "")
	set(LLVM_EXTERNALIZE_DEBUGINFO ON CACHE BOOL "")			set(LLVM_EXTERNALIZE_DEBUGINFO ON CACHE BOOL "")
	set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "")			set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "")

	set(LLVM_ENABLE_LTO ON CACHE BOOL "")			set(LLVM_ENABLE_LTO ON CACHE BOOL "")
	if(NOT APPLE)			if(NOT APPLE)
	set(LLVM_ENABLE_LLD ON CACHE BOOL "")			set(LLVM_ENABLE_LLD ON CACHE BOOL "")
	set(CLANG_DEFAULT_LINKER lld CACHE STRING "")			set(CLANG_DEFAULT_LINKER lld CACHE STRING "")
				set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "")
	endif()			endif()

	if(APPLE)			if(APPLE)
	set(LLDB_CODESIGN_IDENTITY "" CACHE STRING "")			set(LLDB_CODESIGN_IDENTITY "" CACHE STRING "")
	endif()			endif()

	set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")			set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
	set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")			set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
	▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines