This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Add missing non-standard ARMv8 architecture variant
ClosedPublic

Authored by yroux on Jan 9 2018, 5:31 AM.

Details

Summary

This change adds the missing armv8l variant as an alias of armv8 architecture.
The issue was observed with several regressions in validation on armv8l
hardware (for instance ExecutionEngine/frem.ll failed due to lack of neon fpu).

Tested with regression testsuite passed without regression on ARM and x86_64.

Diff Detail

Repository
rL LLVM

Event Timeline

yroux created this revision.Jan 9 2018, 5:31 AM
fhahn added a subscriber: fhahn.

LGTM thanks! Adding some more people who might be interested. I assume armv8l is a Linaro variant?

yroux added a comment.Jan 9 2018, 6:21 AM

Thanks fro the review Florian, armv8l is not Linaro specific it is how the kernel and some distro reference ARMv8 LittleEndian targets. BTW, I didn't manage to find where it comes from in first place

fhahn accepted this revision.Jan 9 2018, 6:24 AM

Thanks, LGTM

This revision is now accepted and ready to land.Jan 9 2018, 6:24 AM
yroux added a comment.Jan 9 2018, 6:29 AM

I don't have the commit rights yet, so it'd be great if you can commit it for me :)

Thanks
Yvan

fhahn added a comment.Jan 9 2018, 7:03 AM

Sure, I'll commit it in a bit

This revision was automatically updated to reflect the committed changes.
fhahn added a comment.Jan 9 2018, 9:51 AM

Committed, thanks! I've tweaked the commit title a bit.