This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
docs/
-
ReleaseNotes.rst

Differential D41837

Add Function multiversion to the release notes.
ClosedPublic

Authored by erichkeane on Jan 8 2018, 2:00 PM.

Download Raw Diff

Details

Reviewers

rsmith
hans
aaron.ballman
echristo

Commits

rGace10a20a66e: Document attribute target multiversioning.
rL322043: Document attribute target multiversioning.
rC322043: Document attribute target multiversioning.

Summary

Richard suggested that I add this feature to the release notes,
so I was hoping someone (anyone willing:) ) could do a quick read
through for me.

Thanks!
-Erich

Diff Detail

Event Timeline

erichkeane created this revision.Jan 8 2018, 2:00 PM

I think you're missing that right now it's x86 only yes? :)

-eric

Ah, right :) Slipped my mind that ELF != x86-linux.

Looks fine. Can you also update include/clang/Basic/AttrDocs.td to mention multiversioning in TargetDocs? Then you can add a few words here to say "consult the documentation for the target attribute for more information" or similar :)

This revision is now accepted and ready to land.Jan 8 2018, 3:20 PM

Closed by commit rC322043: Document attribute target multiversioning. (authored by erichkeane). · Explain WhyJan 8 2018, 3:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

docs/

ReleaseNotes.rst

5 lines

Diff 128980

docs/ReleaseNotes.rst

Context not available.
	Attribute Changes in Clang	Attribute Changes in Clang
	--------------------------	--------------------------

		- Clang now supports function multiversioning with attribute 'target' on ELF
		based environments by using indirect functions. This implementation has a few
		minor limitations over the GCC implementation for the sake of AST sanity,
		however it is otherwise compatible with existing code using this feature for
		GCC.
	- ...	- ...

	Windows Support	Windows Support
Context not available.