This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Delete CanExitEarly
ClosedPublic

Authored by smeenai on Jan 7 2018, 10:09 PM.

Reviewers

Commits

Summary

It was being set but never used, and its value is only ever needed
locally in lld::coff::link.

Repository

rLLD LLVM Linker

Build Status

Buildable 13576
Build 13576: arc lint + arc unit

This revision is now accepted and ready to land.Jan 7 2018, 10:18 PM

LGTM

This revision was automatically updated to reflect the committed changes.

Path

Size

COFF/

1 line

1 line

Show First 20 Lines • Show All 158 Lines • ▼ Show 20 Lines	struct Configuration {
uint64_t StackReserve = 1024 * 1024;		uint64_t StackReserve = 1024 * 1024;
uint64_t StackCommit = 4096;		uint64_t StackCommit = 4096;
uint64_t HeapReserve = 1024 * 1024;		uint64_t HeapReserve = 1024 * 1024;
uint64_t HeapCommit = 4096;		uint64_t HeapCommit = 4096;
uint32_t MajorImageVersion = 0;		uint32_t MajorImageVersion = 0;
uint32_t MinorImageVersion = 0;		uint32_t MinorImageVersion = 0;
uint32_t MajorOSVersion = 6;		uint32_t MajorOSVersion = 6;
uint32_t MinorOSVersion = 0;		uint32_t MinorOSVersion = 0;
bool CanExitEarly = false;
bool DynamicBase = true;		bool DynamicBase = true;
bool AllowBind = true;		bool AllowBind = true;
bool NxCompat = true;		bool NxCompat = true;
bool AllowIsolation = true;		bool AllowIsolation = true;
bool TerminalServerAware = true;		bool TerminalServerAware = true;
bool LargeAddressAware = false;		bool LargeAddressAware = false;
bool HighEntropyVA = false;		bool HighEntropyVA = false;
bool AppContainer = false;		bool AppContainer = false;
Show All 10 Lines

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines	bool link(ArrayRef<const char *> Args, bool CanExitEarly, raw_ostream &Diag) {
errorHandler().ErrorOS = &Diag;		errorHandler().ErrorOS = &Diag;
errorHandler().ColorDiagnostics = Diag.has_colors();		errorHandler().ColorDiagnostics = Diag.has_colors();
errorHandler().ErrorLimitExceededMsg =		errorHandler().ErrorLimitExceededMsg =
"too many errors emitted, stopping now"		"too many errors emitted, stopping now"
" (use /ERRORLIMIT:0 to see all errors)";		" (use /ERRORLIMIT:0 to see all errors)";
errorHandler().ExitEarly = CanExitEarly;		errorHandler().ExitEarly = CanExitEarly;
Config = make<Configuration>();		Config = make<Configuration>();
Config->Argv = {Args.begin(), Args.end()};		Config->Argv = {Args.begin(), Args.end()};
Config->CanExitEarly = CanExitEarly;

Symtab = make<SymbolTable>();		Symtab = make<SymbolTable>();

Driver = make<LinkerDriver>();		Driver = make<LinkerDriver>();
Driver->link(Args);		Driver->link(Args);

// Call exit() if we can to avoid calling destructors.		// Call exit() if we can to avoid calling destructors.
if (CanExitEarly)		if (CanExitEarly)
▲ Show 20 Lines • Show All 1,264 Lines • Show Last 20 Lines