Page MenuHomePhabricator

Ignore the DISPATCH_NOESCAPE if not defined
ClosedPublic

Authored by kongyi on Dec 27 2017, 3:27 PM.

Details

Summary

This macro is only defined after XCode 8, causing build breakage for build systems with prior versions. Ignore DISPATCH_NOESCAPE if not defined.

Diff Detail

Repository
rL LLVM

Event Timeline

kongyi created this revision.Dec 27 2017, 3:27 PM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. · View Herald TranscriptDec 27 2017, 3:27 PM

Thanks for fixing this.

Can you make this simpler by defining DISPATCH_NOESCAPE only when it hasn't been defined?

#ifndef DISPATCH_NOESCAPE
#define DISPATCH_NOESCAPE
#endif
kongyi updated this revision to Diff 128306.Dec 28 2017, 2:15 PM

Thanks for fixing this.

Can you make this simpler by defining DISPATCH_NOESCAPE only when it hasn't been defined?

#ifndef DISPATCH_NOESCAPE
#define DISPATCH_NOESCAPE
#endif

Done

ahatanak accepted this revision.Dec 28 2017, 2:22 PM

Looks good

This revision is now accepted and ready to land.Dec 28 2017, 2:22 PM
This revision was automatically updated to reflect the committed changes.