Page MenuHomePhabricator

[OpenMP][Clang] Add missing argument to runtime functions.
AbandonedPublic

Authored by gtbercea on Dec 21 2017, 4:35 AM.

Details

Summary

This patch adds a missing argument to the runtime interface. Tests are adjusted accordingly.

Diff Detail

Repository
rL LLVM

Event Timeline

gtbercea created this revision.Dec 21 2017, 4:35 AM
Hahnfeld requested changes to this revision.Dec 21 2017, 4:38 AM

D41012? This patch doesn't update the documentation with function signatures.

This revision now requires changes to proceed.Dec 21 2017, 4:38 AM

D41012? This patch doesn't update the documentation with function signatures.

Ok so I see that your patch uses a different order of the arguments. I've just added the data sharing related arguments at the end and this matches the libomptarget patch I just posted. Which way do we want to do this?

gtbercea updated this revision to Diff 127865.Dec 21 2017, 4:58 AM

Address comments.

Not needed anymore, we decided on the order of arguments in D41012.

gtbercea abandoned this revision.Jan 3 2018, 4:00 AM

Functionality already landed. See previous comment.