Page MenuHomePhabricator

[hwasan] Implement -fsanitize-recover=hwaddress.
ClosedPublic

Authored by eugenis on Dec 19 2017, 3:37 PM.

Event Timeline

eugenis created this revision.Dec 19 2017, 3:37 PM
kcc accepted this revision.Dec 19 2017, 4:10 PM

LGTM with a nit

compiler-rt/lib/hwasan/hwasan.cc
254–255

I'd prefer enums to booleans, for better readability

This revision is now accepted and ready to land.Dec 19 2017, 4:10 PM
eugenis added inline comments.Dec 19 2017, 4:43 PM
compiler-rt/lib/hwasan/hwasan.cc
254–255

good idea!

eugenis updated this revision to Diff 127640.Dec 19 2017, 5:54 PM

Replaced booleans with enums.
Added __builtin_unreachable in non-recover variants of callbacks.

eugenis updated this revision to Diff 127642.Dec 19 2017, 6:12 PM

Tweaked a test.

This revision was automatically updated to reflect the committed changes.