Apparently the -fsanitize flag hadn't been added for Scudo upstream yet. Whups!
Let me know if there are more comprehensive tests I should be adding~
Differential D41413
[scudo] Add -fsanitize=scudo option to Fuchsia. flowerhack on Dec 19 2017, 2:15 PM. Authored by
Details Apparently the -fsanitize flag hadn't been added for Scudo upstream yet. Whups! Let me know if there are more comprehensive tests I should be adding~
Diff Detail Event TimelineComment Actions As discussed: you probably want to enforce mutual exclusion of the sanitizers (eg: ASan is not compatible with Scudo). Comment Actions Mutual exclusion is not target-specific and is already handled in SanitizerArgs. The test coverage for that looks fine.
Comment Actions LGTM % nits
|
Can you use just the tuple triple target form, i.e. x86_64-fuchsia? We should cleanup the rest of the file to use the same format but I'll do that in a separate change.