Page MenuHomePhabricator

[scudo] Add -fsanitize=scudo option to Fuchsia.

Authored by flowerhack on Dec 19 2017, 2:15 PM.



Apparently the -fsanitize flag hadn't been added for Scudo upstream yet. Whups!

Let me know if there are more comprehensive tests I should be adding~

Diff Detail

rC Clang

Event Timeline

flowerhack created this revision.Dec 19 2017, 2:15 PM

As discussed: you probably want to enforce mutual exclusion of the sanitizers (eg: ASan is not compatible with Scudo).
I have not test Scudo+Safestack but they should be compatible (or at least with a small amount of work can should be made to be).

flowerhack edited the summary of this revision. (Show Details)
flowerhack added reviewers: mcgrathr, phosek.
mcgrathr accepted this revision.Dec 19 2017, 5:12 PM

Mutual exclusion is not target-specific and is already handled in SanitizerArgs. The test coverage for that looks fine.


Never have a file that does not end with a newline.

This revision is now accepted and ready to land.Dec 19 2017, 5:12 PM
phosek accepted this revision.Dec 19 2017, 5:13 PM

LGTM % nits


Can you use just the tuple triple target form, i.e. x86_64-fuchsia? We should cleanup the rest of the file to use the same format but I'll do that in a separate change.

flowerhack marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.