Page MenuHomePhabricator

[clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.
ClosedPublic

Authored by hokein on Dec 19 2017, 5:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Dec 19 2017, 5:52 AM
sammccall accepted this revision.Dec 19 2017, 7:38 AM
sammccall added inline comments.
clangd/clients/clangd-vscode/README.md
16 ↗(On Diff #127510)

The fact that you need to install clangd seems to belong here, not as "configuration".

39 ↗(On Diff #127510)

node.js

clangd/clients/clangd-vscode/package.json
46 ↗(On Diff #127510)

use the SVN path?
npm says this should be a machine readable SCM url, which these github web urls aren't.

consider adding homepage/bugtracker, which are also shown on the marketplace page: https://marketplace.visualstudio.com/items?itemName=tht13.python

This revision is now accepted and ready to land.Dec 19 2017, 7:38 AM
hokein updated this revision to Diff 127529.Dec 19 2017, 8:01 AM
hokein marked 3 inline comments as done.

Address review comments and add license.

This revision was automatically updated to reflect the committed changes.