Page MenuHomePhabricator

[X86][CLFLUSH]: Adding full coverage of MC encoding for the CLFLUSH isa sets.<NFC>
ClosedPublic

Authored by gadi.haber on Dec 17 2017, 4:02 AM.

Details

Summary

NFC.
Adding MC regressions tests to cover the CLFLSH and CLFLUSHOPT isa sets.
This patch is part of a larger task to cover MC encoding of all X86 isa sets started in revision: https://reviews.llvm.org/D39952

Diff Detail

Repository
rL LLVM

Event Timeline

gadi.haber created this revision.Dec 17 2017, 4:02 AM
RKSimon added a subscriber: asb.Dec 17 2017, 4:21 AM

For these simpler cases (D41331, D41328, etc.) would it be possible to add @asb's disassembler tests right away? I got the impression from D40879 that only some more complex instructions had a problem with the 'round trip' testing?

I can try to add them in. However, we should consider opening a proper bugzilla to convert ALL the MC tests to use asb proposal, since the llvm-objdump is not always compatible with llvm-mc on x86.

This revision is now accepted and ready to land.Dec 17 2017, 10:33 AM
This revision was automatically updated to reflect the committed changes.