This is an archive of the discontinued LLVM Phabricator instance.

[X86][RD]: Adding full coverage of MC encoding for RD isa sets.<NFC>

Authored by gadi.haber on Dec 16 2017, 11:49 PM.



Adding MC regressions tests to cover RDPMC, RDRAND, RDRAND, RDSEED, RDTSCP, DWRFSGS isa sets.
This patch is part of a larger task to cover MC encoding of all X86 isa sets started in revision:

Diff Detail


Event Timeline

gadi.haber created this revision.Dec 16 2017, 11:49 PM

What about rdfsbaseq/rdgsbaseq/wrfsbaseq/wrgsbaseq?

And rdrandq/rdseedq/rdrandw/rseedw?

Added rdseedw,rdseedq, rdrandw, rdrandq instructions.

Added tests for rdfsbaseq,,rdgsbaseq, wrfsbaseq, wrgsbaseq

Unfortunately the following instruction mnemonics are not supported by llvm-mc:
rdfsbasew, rdgsbasew, wrfsbasw, wrgsbasew

For example:
$ echo "wrgsbasew %r13w" | llvm-mc -triple=x86_64


<stdin>:1:1: error: invalid instruction mnemonic 'wrgsbasew'
wrgsbasew %r13w

craig.topper accepted this revision.Dec 21 2017, 1:55 PM

There is no wrgsbasew instruction defined according to the SDM.


This revision is now accepted and ready to land.Dec 21 2017, 1:55 PM
This revision was automatically updated to reflect the committed changes.