This is an archive of the discontinued LLVM Phabricator instance.

Differential D41328

[X86][RD]: Adding full coverage of MC encoding for RD isa sets.<NFC>
ClosedPublic

Authored by gadi.haber on Dec 16 2017, 11:49 PM.

Details

Reviewers
zvi
craig.topper
RKSimon
AndreiGrischenko
Commits
rG309b06cb5c6f: [X86][RD]: Adding full coverage of MC encoding for RD isa sets.<NFC>
rL321476: [X86][RD]: Adding full coverage of MC encoding for RD isa sets.<NFC>
Summary

NFC.
Adding MC regressions tests to cover RDPMC, RDRAND, RDRAND, RDSEED, RDTSCP, DWRFSGS isa sets.
This patch is part of a larger task to cover MC encoding of all X86 isa sets started in revision: https://reviews.llvm.org/D39952

Diff Detail

Repository
rL LLVM

Event Timeline

gadi.haber created this revision.Dec 16 2017, 11:49 PM
RKSimon mentioned this in D41331: [X86][CLFLUSH]: Adding full coverage of MC encoding for the CLFLUSH isa sets.<NFC>.Dec 17 2017, 4:21 AM
craig.topper added a comment.Dec 17 2017, 10:52 AM

What about rdfsbaseq/rdgsbaseq/wrfsbaseq/wrgsbaseq?

craig.topper added a comment.Dec 17 2017, 10:53 AM

And rdrandq/rdseedq/rdrandw/rseedw?

gadi.haber edited reviewers, added: AndreiGrischenko; removed: m_zuckerman.Dec 20 2017, 10:20 AM
gadi.haber updated this revision to Diff 127850.Dec 21 2017, 2:57 AM

Added rdseedw,rdseedq, rdrandw, rdrandq instructions.

gadi.haber updated this revision to Diff 127853.Dec 21 2017, 3:05 AM

Added tests for rdfsbaseq,,rdgsbaseq, wrfsbaseq, wrgsbaseq

gadi.haber added a comment.Dec 21 2017, 3:07 AM

Unfortunately the following instruction mnemonics are not supported by llvm-mc:
rdfsbasew, rdgsbasew, wrfsbasw, wrgsbasew

For example:
$ echo "wrgsbasew %r13w" | llvm-mc -triple=x86_64

.text

<stdin>:1:1: error: invalid instruction mnemonic 'wrgsbasew'
wrgsbasew %r13w

craig.topper accepted this revision.Dec 21 2017, 1:55 PM

There is no wrgsbasew instruction defined according to the SDM.

LGTM

This revision is now accepted and ready to land.Dec 21 2017, 1:55 PM
Closed by commit rL321476: [X86][RD]: Adding full coverage of MC encoding for RD isa sets.<NFC> (authored by gadi.haber). · Explain WhyDec 27 2017, 12:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
MC/
X86/
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
6 lines
18 lines

Diff 127266

test/MC/X86/RDPMC-32.s

  • This file was added.
// RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdpmc
// CHECK: encoding: [0x0f,0x33]
rdpmc

test/MC/X86/RDPMC-64.s

  • This file was added.
// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdpmc
// CHECK: encoding: [0x0f,0x33]
rdpmc

test/MC/X86/RDRAND-32.s

  • This file was added.
// RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdrandl %eax
// CHECK: encoding: [0x0f,0xc7,0xf0]
rdrandl %eax

test/MC/X86/RDRAND-64.s

  • This file was added.
// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdrandl %r13d
// CHECK: encoding: [0x41,0x0f,0xc7,0xf5]
rdrandl %r13d

test/MC/X86/RDSEED-32.s

  • This file was added.
// RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdseedl %eax
// CHECK: encoding: [0x0f,0xc7,0xf8]
rdseedl %eax

test/MC/X86/RDSEED-64.s

  • This file was added.
// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdseedl %r13d
// CHECK: encoding: [0x41,0x0f,0xc7,0xfd]
rdseedl %r13d

test/MC/X86/RDTSCP-32.s

  • This file was added.
// RUN: llvm-mc -triple i386-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdtscp
// CHECK: encoding: [0x0f,0x01,0xf9]
rdtscp

test/MC/X86/RDTSCP-64.s

  • This file was added.
// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdtscp
// CHECK: encoding: [0x0f,0x01,0xf9]
rdtscp

test/MC/X86/RDWRFSGS-64.s

  • This file was added.
// RUN: llvm-mc -triple x86_64-unknown-unknown --show-encoding %s | FileCheck %s
// CHECK: rdfsbasel %r13d
// CHECK: encoding: [0xf3,0x41,0x0f,0xae,0xc5]
rdfsbasel %r13d
// CHECK: rdgsbasel %r13d
// CHECK: encoding: [0xf3,0x41,0x0f,0xae,0xcd]
rdgsbasel %r13d
// CHECK: wrfsbasel %r13d
// CHECK: encoding: [0xf3,0x41,0x0f,0xae,0xd5]
wrfsbasel %r13d
// CHECK: wrgsbasel %r13d
// CHECK: encoding: [0xf3,0x41,0x0f,0xae,0xdd]
wrgsbasel %r13d