This is an archive of the discontinued LLVM Phabricator instance.

Added a separate install target for compilert-rt-headers
ClosedPublic

Authored by ilya-biryukov on Dec 14 2017, 8:22 AM.

Details

Summary

This patch adds a new install target install-compilert-rt-headers,
that is similar to install-clang-headers.

It allows to install the headers without installing all of
compiler-rt.

Diff Detail

Repository
rL LLVM

Event Timeline

ilya-biryukov created this revision.Dec 14 2017, 8:22 AM
Herald added subscribers: Restricted Project, mgorny. · View Herald TranscriptDec 14 2017, 8:22 AM

This is a resubmission of D41164, which was accidentally "commanded" back from me.

beanz accepted this revision.Dec 14 2017, 9:42 AM
beanz added a subscriber: beanz.

This patch LGTM.

This revision is now accepted and ready to land.Dec 14 2017, 9:42 AM

Isn't this gonna break building compiler-rt standalone (i.e. without LLVM)? Or does the include/ directory already rely on LLVM in some other way? See the history of D40687.

ilya-biryukov planned changes to this revision.Dec 15 2017, 2:38 AM

Isn't this gonna break building compiler-rt standalone (i.e. without LLVM)? Or does the include/ directory already rely on LLVM in some other way? See the history of D40687.

I was not aware of this use-case, thanks for mentioning it. It would definitely break without LLVM.
I'll update the patch to not use add_llvm_install_targets.

  • Use add_custom_target directly instead of add_llvm_install_targets
This revision is now accepted and ready to land.Dec 15 2017, 5:07 AM

Removed a usage of add_llvm_install_targets, so it should now work for standalone builds too.

I double-checked that the new targets work with standalone build before submitting.

This revision was automatically updated to reflect the committed changes.