This is an archive of the discontinued LLVM Phabricator instance.

Differential D4115

[mips][mips64r6] bc1any[24] are not available on MIPS32r6/MIPS64r6
ClosedPublic

Authored by dsanders on Jun 12 2014, 5:43 AM.

Details

Reviewers
jkolek
vmedic
zoran.jovanovic
Commits
rGaf8b32e1766e: [mips][mips64r6] bc1any[24] are not available on MIPS32r6/MIPS64r6
rL210899: [mips][mips64r6] bc1any[24] are not available on MIPS32r6/MIPS64r6
Summary

These MIPS-3D instructions have never been implemented in LLVM so we only
add testcases.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 10351.Jun 12 2014, 5:43 AM
dsanders retitled this revision from to [mips][mips64r6] bc1any[24] are not available on MIPS32r6/MIPS64r6.
dsanders updated this object.
dsanders edited the test plan for this revision. (Show Details)
dsanders added reviewers: vmedic, zoran.jovanovic, jkolek.
dsanders added a parent revision: D4114: [mips][mips64r6] b(ge|lt)zal are not available on MIPS32r6/MIPS64r6 and bal is a normal instruction.Jun 12 2014, 5:45 AM
vmedic accepted this revision.Jun 13 2014, 1:18 AM
vmedic edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 13 2014, 1:18 AM
dsanders closed this revision.Jun 13 2014, 6:16 AM

Revision Contents

PathSize
lib/
Target/
Mips/
1 line
test/
MC/
Mips/
mips32r6/
11 lines
mips64r6/
6 lines

Diff 10351

lib/Target/Mips/Mips32r6InstrInfo.td

Show All 19 Lines
// Reencoded: jr -> jalr // Reencoded: jr -> jalr
// Reencoded: jr.hb -> jalr.hb // Reencoded: jr.hb -> jalr.hb
// Reencoded: ldc2 // Reencoded: ldc2
// Reencoded: ll, sc // Reencoded: ll, sc
// Reencoded: lwc2 // Reencoded: lwc2
// Reencoded: sdbbp // Reencoded: sdbbp
// Reencoded: sdc2 // Reencoded: sdc2
// Reencoded: swc2 // Reencoded: swc2
// Removed: bc1any2, bc1any4
// Rencoded: [ls][wd]c2 // Rencoded: [ls][wd]c2
def brtarget21 : Operand<OtherVT> { def brtarget21 : Operand<OtherVT> {
let EncoderMethod = "getBranchTarget21OpValue"; let EncoderMethod = "getBranchTarget21OpValue";
let OperandType = "OPERAND_PCREL"; let OperandType = "OPERAND_PCREL";
let DecoderMethod = "DecodeBranchTarget21"; let DecoderMethod = "DecodeBranchTarget21";
let ParserMatchClass = MipsJumpTargetAsmOperand; let ParserMatchClass = MipsJumpTargetAsmOperand;
} }
▲ Show 20 Lines • Show All 645 Lines • Show Last 20 Lines

test/MC/Mips/mips32r6/invalid-mips5-wrong-error.s

  • This file was added.
# Instructions that are invalid but currently emit the wrong error message.
#
# RUN: not llvm-mc %s -triple=mips-unknown-linux -show-encoding -mcpu=mips32r6 \
# RUN: 2>%t1
# RUN: FileCheck %s < %t1
.set noat
bc1any2f $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any2t $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any4f $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any4t $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction

test/MC/Mips/mips64r6/invalid-mips5-wrong-error.s

# Instructions that are invalid # Instructions that are invalid but currently emit the wrong error message.
# #
# RUN: not llvm-mc %s -triple=mips64-unknown-linux -show-encoding -mcpu=mips64r6 \ # RUN: not llvm-mc %s -triple=mips64-unknown-linux -show-encoding -mcpu=mips64r6 \
# RUN: 2>%t1 # RUN: 2>%t1
# RUN: FileCheck %s < %t1 # RUN: FileCheck %s < %t1
.set noat .set noat
abs.ps $f22,$f8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction abs.ps $f22,$f8 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
add.ps $f25,$f27,$f13 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction add.ps $f25,$f27,$f13 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
alnv.ps $f12,$f18,$f30,$12 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction alnv.ps $f12,$f18,$f30,$12 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any2f $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any2t $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any4f $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
bc1any4t $fcc2,4 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.eq.ps $fcc5,$f0,$f9 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.eq.ps $fcc5,$f0,$f9 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.f.ps $fcc6,$f11,$f11 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.f.ps $fcc6,$f11,$f11 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.le.ps $fcc1,$f7,$f20 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.le.ps $fcc1,$f7,$f20 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.lt.ps $f19,$f5 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.lt.ps $f19,$f5 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.nge.ps $f1,$f26 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.nge.ps $f1,$f26 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.ngl.ps $f21,$f30 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.ngl.ps $f21,$f30 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.ngle.ps $fcc7,$f12,$f20 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.ngle.ps $fcc7,$f12,$f20 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
c.ngt.ps $fcc5,$f30,$f6 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction c.ngt.ps $fcc5,$f30,$f6 # CHECK: :[[@LINE]]:{{[0-9]+}}: error: Unknown instruction
Show All 26 Lines