This is an archive of the discontinued LLVM Phabricator instance.

Tests for D34515

Authored by rogfer01 on Dec 12 2017, 10:25 AM.



As suggested by @efriedma make the new tests and RUN lines in D34515 a change of its own.

Diff Detail


Event Timeline

rogfer01 created this revision.Dec 12 2017, 10:25 AM

I guess I didn't explain my comment completely in the other review. The point is that you submit the new tests with CHECK lines that pass on master, then modify CHECK lines in the second patch, to make it clear how the patch modifies the generated code.

Oh, that makes a lot of sense. I'll do. Sorry for the misunderstanding.

rogfer01 updated this revision to Diff 126982.Dec 14 2017, 9:27 AM
rogfer01 added a reviewer: samparker.


  • New tests before D34515 is applied showing current codegen (and not after like I did the last time)
This revision is now accepted and ready to land.Dec 14 2017, 11:19 AM
This revision was automatically updated to reflect the committed changes.