[LLD] [COFF] Disallow -dynamicbase:no for arm and arm64

[mstorsjo]

Summary

This matches what MSVC link.exe does.

[ruiu]

LGTM with this change.

test/COFF/armnt-dynamicbase.test

4

You can merge this file and the assembly file because this file contains only comments.

[mstorsjo]

test/COFF/armnt-dynamicbase.test

4

Which assembly file? This uses a different source file than the other test (which is for arm64); this uses a preexisting input file from the inputs subdirectory. But I could use a similar inline asm sub here as well instead of the inputs subdirectory yaml file, for consistency.

[ruiu]

LGTM

test/COFF/armnt-dynamicbase.test

4

Ah, sorry I'm confused. Don't mind.

COFF/Driver.cpp

void LinkerDriver::link(ArrayRef<const char *> ArgsArr) {
   Config->LargeAddressAware = Args.hasFlag(
       OPT_largeaddressaware, OPT_largeaddressaware_no, Config->is64());
 
   // Handle /highentropyva
   Config->HighEntropyVA =
       Config->is64() &&
       Args.hasFlag(OPT_highentropyva, OPT_highentropyva_no, true);
 
+  if (!Config->DynamicBase &&
+      (Config->Machine == ARMNT || Config->Machine == ARM64))
+    error("/dynamicbase:no is not compatible with " +
+          machineToStr(Config->Machine));
+
   // Handle /entry and /dll
   if (auto *Arg = Args.getLastArg(OPT_entry)) {
     Config->Entry = addUndefined(mangle(Arg->getValue()));
   } else if (!Config->Entry && !Config->NoEntry) {
     if (Args.hasArg(OPT_dll)) {
       StringRef S = (Config->Machine == I386) ? "__DllMainCRTStartup@12"
                                               : "_DllMainCRTStartup";
       Config->Entry = addUndefined(S);

test/COFF/arm64-dynamicbase.s

+// REQUIRES: aarch64
+// RUN: llvm-mc -filetype=obj -triple=aarch64-windows %s -o %t.obj
+// RUN: not lld-link -entry:_start -subsystem:console %t.obj -out:%t.exe -dynamicbase:no 2>&1 | FileCheck %s
+ .globl _start
+_start:
+ ret
+
+# CHECK: dynamicbase:no is not compatible with arm64

test/COFF/armnt-dynamicbase.test

+# RUN: yaml2obj < %p/Inputs/armnt-executable.obj.yaml > %t.obj
+# RUN: not lld-link /out:%t.exe /entry:mainCRTStartup /subsystem:console %t.obj /dynamicbase:no 2>&1 | FileCheck %s
+# CHECK: dynamicbase:no is not compatible with arm