This is an archive of the discontinued LLVM Phabricator instance.

[ubsan] Use pass_object_size info in bounds checks (compiler-rt)
ClosedPublic

Authored by vsk on Dec 6 2017, 7:46 PM.

Details

Summary

This is a test update for the clang change in https://reviews.llvm.org/D40940

Diff Detail

Event Timeline

vsk created this revision.Dec 6 2017, 7:46 PM

If the answer to my question is "no, it'll just work," LGTM. Thanks!

test/ubsan/TestCases/Misc/bounds.cpp
9

Do we need extra RUN: lines/CHECK prefixes for these? I thought ubsan runtime errors terminated the program.

vsk added inline comments.Dec 7 2017, 4:27 PM
test/ubsan/TestCases/Misc/bounds.cpp
9

We don't -- this test doesn't use ubsan's trapping mode. I'll try not to fat-finger the command to generate diff context next time -- this would've been clearer with the compile line present.

george.burgess.iv accepted this revision.Dec 7 2017, 4:28 PM
This revision is now accepted and ready to land.Dec 7 2017, 4:28 PM
vsk closed this revision.Dec 8 2017, 11:26 AM

Landed in r320129.