We now have several options that apply for both libraries and they
shouldn't be documented in multiple files. When already merging
the two Build_With_CMake.txt documents, convert them to
reStructuredText which is used for all of LLVM's documentation.
Details
Diff Detail
Event Timeline
This is a first version, I will do another pass tomorrow. Proof-reading would be much appreciated :-)
README.rst | ||
---|---|---|
40 | all values (remove "the") | |
186 | What is that question mark? | |
231 | assembly --> assembler? | |
256–258 | We had an internal discussion about it. Do we have consensus that we'll support bclib? | |
281 | I think we should we also include something like: **LIBOMPTARGET_NVPTX_DEBUG** Enable printing of debug messages from the nvptx runtime. Following you comments on the nvptx patch, I added this entry in my local branch and I was planning to include it in the next diff. You can add it in this patch instead. However, there are no ON or OFF options, the symbol is either defined or not defined. | |
317–318 | Remove commas before "and" (2 places). |
README.rst | ||
---|---|---|
277 | The default is still sm_30, let's patch clang first to use sm_35. Also, given that the nvptx runtime cannot be built with sm<35, should we add to the description that sm_35 is the minimum required? |
Improvements based on review comments and extensions to some paragraphs.
README.rst | ||
---|---|---|
256–258 | For now, I've only copied what has been in libomptarget/Build_With_CMake.txt. To be honest I think we should remove this paragraph entirely because the NVPTX runtime hasn't been committed yet so that we don't confuse the users. | |
317–318 | Some of the comas are intentional to be consistent with the rest of LLVM's documentation: https://en.wikipedia.org/wiki/Serial_comma |
all values (remove "the")