This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Change the DWARF v5 string offsets table tests to generate the test object as part of the test.
ClosedPublic

Authored by wolfgangp on Dec 6 2017, 11:56 AM.

Details

Reviewers
aprantl
dblaikie
Summary

The DWARF v5 string offsets table tests currently use pre-generated object files that are checked into llvm/test/DebugInfo/Inputs. To avoid this, this change moves the assembly files that are used to generate the objects into DebugInfo/X86 and augments them to use llvm-mc to generate the objects as temporary files, and then goes on to do the actual test. This enables us to remove the objects as well as the test scripts.

Diff Detail

Event Timeline

wolfgangp created this revision.Dec 6 2017, 11:56 AM
aprantl accepted this revision.Dec 6 2017, 12:40 PM

That sounds like a good idea.

This revision is now accepted and ready to land.Dec 6 2017, 12:40 PM

This will likely not work on Darwin until we undo @davide's change in rL319995. I'm guessing that is the reason you didn't land this yet?

This will likely not work on Darwin until we undo @davide's change in rL319995. I'm guessing that is the reason you didn't land this yet?

nvm, I (mis)read line tables.

wolfgangp closed this revision.Dec 19 2017, 8:56 AM
test/DebugInfo/dwarfdump-str-offsets-dwp.test