[lld] Fix handling of wildcards in dynamic lists.

[ruiu]

LGTM

Wow. I was surprised that we didn't notice this until now. Thank you for finding this out.

lld/ELF/SymbolTable.cpp

for (SymbolVersion &Ver : Config->VersionScriptLocals)
     assignWildcardVersion(Ver, VER_NDX_LOCAL);
 }
 
 // Handles -dynamic-list.
 void SymbolTable::handleDynamicList() {
   for (SymbolVersion &Ver : Config->DynamicList) {
     std::vector<Symbol *> Syms;
     if (Ver.HasWildcard)
-      Syms = findByVersion(Ver);
-    else
       Syms = findAllByVersion(Ver);
+    else
+      Syms = findByVersion(Ver);
 
     for (Symbol *B : Syms) {
       if (!Config->Shared)
         B->ExportDynamic = true;
       else if (B->includeInDynsym())
         B->IsPreemptible = true;
     }
   }

lld/test/ELF/dynamic-list-wildcard.s

+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+
+# RUN: echo "{ foo1*; };" > %t.list
+# RUN: ld.lld --hash-style=sysv -pie --dynamic-list %t.list %t -o %t.exe
+# RUN: llvm-readobj -dyn-symbols %t.exe | FileCheck %s
+
+# CHECK:      DynamicSymbols [
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name:  @ (0)
+# CHECK-NEXT:     Value:   0x0
+# CHECK-NEXT:     Size:  0
+# CHECK-NEXT:     Binding:   Local (0x0)
+# CHECK-NEXT:     Type:  None (0x0)
+# CHECK-NEXT:     Other:   0
+# CHECK-NEXT:     Section:   Undefined (0x0)
+# CHECK-NEXT:   }
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name:  foo1@ (1)
+# CHECK-NEXT:     Value:   0x1000
+# CHECK-NEXT:     Size:  0
+# CHECK-NEXT:     Binding:   Global (0x1)
+# CHECK-NEXT:     Type:  None (0x0)
+# CHECK-NEXT:     Other:   0
+# CHECK-NEXT:     Section:   .text (0x4)
+# CHECK-NEXT:   }
+# CHECK-NEXT:   Symbol {
+# CHECK-NEXT:     Name:  foo11@ (6)
+# CHECK-NEXT:     Value:   0x1001
+# CHECK-NEXT:     Size:  0
+# CHECK-NEXT:     Binding:   Global (0x1)
+# CHECK-NEXT:     Type:  None (0x0)
+# CHECK-NEXT:     Other:   0
+# CHECK-NEXT:     Section:   .text (0x4)
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+
+.globl foo1
+foo1:
+  ret
+
+.globl foo11
+foo11:
+  ret
+
+.globl foo2
+foo2:
+  ret
+
+.globl _start
+_start:
+  retq