This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Split CodeComplete into a separate file. NFC
ClosedPublic

Authored by sammccall on Dec 1 2017, 6:12 AM.

Diff Detail

Event Timeline

sammccall created this revision.Dec 1 2017, 6:12 AM
hokein accepted this revision.Dec 4 2017, 5:31 AM

LGTM.

clangd/CodeComplete.h
11

nit: I prefer to put this comment below (near a class or function) to make it more obvious :) -- the same to other places.

81

nit: a blank line.

clangd/Compiler.h
17

nit : a blank line.

This revision is now accepted and ready to land.Dec 4 2017, 5:31 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
sammccall marked 2 inline comments as done.