This is an archive of the discontinued LLVM Phabricator instance.

Mark all library-defined command line options as hidden
ClosedPublic

Authored by zturner on Nov 30 2017, 1:33 PM.

Details

Summary

These command line options are not intended for public use, and often don't even make sense in the context of a particular tool anyway. About 90% of them are already hidden, but when people add new options they forget to hide them, so if you were to make a brand new tool today, link against one of LLVM's libraries, and run tool -help you would get a bunch of junk that doesn't make sense for the tool you're writing.

This patch hides these options. The real solution is to not have libraries defining command line options, but that's a much larger effort and not something I'm prepared to take on.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner created this revision.Nov 30 2017, 1:33 PM
rnk accepted this revision.Nov 30 2017, 2:33 PM

Looks good to me. If someone cares, they can move the option to CommandFlags.def to get it back into llc help.

This revision is now accepted and ready to land.Nov 30 2017, 2:33 PM
This revision was automatically updated to reflect the committed changes.