This is an archive of the discontinued LLVM Phabricator instance.

source/Utility/UUID.cpp
77–78	Minor nit, but when you have a string and only want to print that string and nothing else, I would usually prefer not using printf syntax and instead just using `PutCString`.

Address @zturner's comment and remove a useless temporary variable.

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

source/

Utility/

9 lines

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines	if (m_num_uuid_bytes == 20) {
u[16], u[17], u[18], u[19]))		u[16], u[17], u[18], u[19]))
result.append(buf);		result.append(buf);
}		}
}		}
return result;		return result;
}		}

void UUID::Dump(Stream *s) const {		void UUID::Dump(Stream *s) const {
const uint8_t u = (const uint8_t )GetBytes();		s->PutCString(GetAsString().c_str());
s->Printf("%2.2X%2.2X%2.2X%2.2X-%2.2X%2.2X-%2.2X%2.2X-%2.2X%2.2X-%2.2X%2.2X%"
"2.2X%2.2X%2.2X%2.2X",
u[0], u[1], u[2], u[3], u[4], u[5], u[6], u[7], u[8], u[9], u[10],
u[11], u[12], u[13], u[14], u[15]);
if (m_num_uuid_bytes == 20) {
s->Printf("-%2.2X%2.2X%2.2X%2.2X", u[16], u[17], u[18], u[19]);
}
}		}
		zturnerUnsubmitted Not Done Reply Inline Actions Minor nit, but when you have a string and only want to print that string and nothing else, I would usually prefer not using printf syntax and instead just using `PutCString`. zturner: Minor nit, but when you have a string and only want to print that string and nothing else, I…

bool UUID::SetBytes(const void *uuid_bytes, uint32_t num_uuid_bytes) {		bool UUID::SetBytes(const void *uuid_bytes, uint32_t num_uuid_bytes) {
if (uuid_bytes) {		if (uuid_bytes) {
switch (num_uuid_bytes) {		switch (num_uuid_bytes) {
case 20:		case 20:
m_num_uuid_bytes = 20;		m_num_uuid_bytes = 20;
break;		break;
case 16:		case 16:
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines