This is an archive of the discontinued LLVM Phabricator instance.

Remove some duplicated code in UUID.cpp
ClosedPublic

Authored by sas on Nov 27 2017, 1:50 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sas created this revision.Nov 27 2017, 1:50 PM
clayborg accepted this revision.Nov 27 2017, 2:09 PM
This revision is now accepted and ready to land.Nov 27 2017, 2:09 PM
davide accepted this revision.Nov 27 2017, 2:20 PM
davide added a subscriber: davide.

LGTM

zturner added inline comments.
source/Utility/UUID.cpp
77–78 ↗(On Diff #124463)

Minor nit, but when you have a string and only want to print that string and nothing else, I would usually prefer not using printf syntax and instead just using PutCString.

sas updated this revision to Diff 124499.Nov 27 2017, 5:24 PM

Address @zturner's comment and remove a useless temporary variable.

This revision was automatically updated to reflect the committed changes.