Page MenuHomePhabricator

[lld] Set up .arcconfig to point to new Diffusion LLD repository
ClosedPublic

Authored by benhamilton on Nov 27 2017, 8:15 AM.

Details

Summary

We want to automatically copy the appropriate mailing list
for review requests to the LLD repository.

For context, see the proposal and discussion here:

http://lists.llvm.org/pipermail/cfe-dev/2017-November/056032.html

Similar to D40179, I set up a new Diffusion repository with callsign
"LLD" for lld:

https://reviews.llvm.org/source/lld/

This explicitly updates lld's .arcconfig to point to the new C
repository in Diffusion, which will let us use Herald rule H270.

Event Timeline

benhamilton created this revision.Nov 27 2017, 8:15 AM
ruiu added inline comments.Nov 27 2017, 8:20 AM
.arcconfig
2

The official name of lld is "lld" and not "LLD".

benhamilton marked an inline comment as done.Nov 27 2017, 8:37 AM
benhamilton added inline comments.
.arcconfig
2

Yes, I made sure the name of the repository is "lld":

https://reviews.llvm.org/source/lld/

However, Phabricator repository callsigns are required to be "short uppercase strings":

https://secure.phabricator.com/book/phabricator/article/diffusion_managing/#basics-callsigns

Each repository can optionally be identified by a "callsign", which is a short uppercase string like "P" (for Phabricator) or "ARC" (for Arcanist).

So, I think we need to use LLD here for the callsign, and lld for the name of the repository, which is how I have set it up.

ruiu edited edge metadata.Nov 27 2017, 9:09 AM

Looks good, but I know little about .arcconfig, so I think you want to get a LGTM from someone who knows about it.

sammccall accepted this revision.Dec 6 2017, 9:30 AM

The idea that I know about this is pretty funny :-)
But this is the same setup that's working well for clang-tools-extra and others.

This revision is now accepted and ready to land.Dec 6 2017, 9:30 AM
This revision was automatically updated to reflect the committed changes.
benhamilton marked an inline comment as done.