This is an archive of the discontinued LLVM Phabricator instance.

[mips] Add warnings for using dsp and msa flags with inappropriate MIPS ISA revisions
ClosedPublic

Authored by mstojanovic on Nov 27 2017, 5:10 AM.

Details

Summary

Dsp and dspr2 require MIPS revision 2, while msa requires revision 5. Adding warnings for cases when these flags are used with earlier revision.

Diff Detail

Event Timeline

mstojanovic created this revision.Nov 27 2017, 5:10 AM

Fixed formatting.

sdardis added inline comments.Dec 4 2017, 2:51 AM
lib/Target/Mips/MipsSubtarget.cpp
130–131

Hoist this to a static member variable of MipsSubtarget, rather than a function static variable.

132–164

Change the message of "the 'msa' extension" to "the 'msa' ASE".

145–149

Change the message of "the 'msa' extension" to "the 'msa' ASE".

155

See my comment about DspWarningPrinted.

test/CodeGen/Mips/dsp_msa_warning.ll
3–30

Check prefixes should be in capital letters, to ensure they stand out.

Addressed review comments.

mstojanovic marked 5 inline comments as done.Dec 4 2017, 12:07 PM
sdardis accepted this revision.Dec 11 2017, 4:47 AM

LGTM with a title fix: inapropriate MIPS revision-> inappropriate MIPS ISA revisions

This revision is now accepted and ready to land.Dec 11 2017, 4:47 AM
mstojanovic retitled this revision from [mips] Add warnings for using dsp and msa flags with inapropriate MIPS revisions to [mips] Add warnings for using dsp and msa flags with inappropriate MIPS ISA revisions.Dec 11 2017, 6:50 AM
This revision was automatically updated to reflect the committed changes.