As part of the unification of the debug format and the MIR format, always print registers as lowercase.
- Only debug printing is affected. It now follows MIR.
Paths
| Differential D40417
[CodeGen] Print register names in lowercase in both MIR and debug output ClosedPublic Authored by thegameg on Nov 24 2017, 3:33 AM.
Details Summary As part of the unification of the debug format and the MIR format, always print registers as lowercase.
Diff Detail Event TimelineHerald added subscribers: JDevlieghere, eraman, javed.absar and 4 others. · View Herald TranscriptNov 24 2017, 3:33 AM Comment Actions LGTM, thanks. I've had one comment about the lowercase printing below. It's only a very minor issue, so feel free to fix this as part of this commit or separate it out into a separate patch.
This revision is now accepted and ready to land.Nov 27 2017, 10:56 AM Closed by commit rL319187: [CodeGen] Print register names in lowercase in both MIR and debug output (authored by thegameg). · Explain WhyNov 28 2017, 9:16 AM This revision was automatically updated to reflect the committed changes. Large DiffThis large diff affects 289 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Diff 124147 lib/CodeGen/TargetRegisterInfo.cpp
|
This creates a temporary std::string object each time.
How about adding a printLowerCase(const char *String, raw_ostream &OS) function to StringExtras.h that transforms the characters to lowercase as they are printed? (May also want to move ascii_tolower() from StringRef.cpp to StringExtras.h to share code).