Page MenuHomePhabricator

Add MemorySSA as loop dependency, disabled by default [NFC].
ClosedPublic

Authored by asbirlea on Nov 20 2017, 4:20 PM.

Details

Summary

First step in adding MemorySSA as dependency for loop pass manager.
Adding the dependency under a flag.

New pass manager: MSSA pointer in LoopStandardAnalysisResults can be null.
Legacy and new pass manager: Use cl::opt EnableMSSALoopDependency. Disabled by default.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.Nov 20 2017, 4:20 PM
davide accepted this revision.Nov 20 2017, 4:30 PM

The plumbing looks good to me.

include/llvm/Analysis/LoopAnalysisManager.h
65 ↗(On Diff #123685)

Ideally we shouldn't have cl::opt in the new pass manager, but given this is supposed to be temporary, I guess it's fine.

This revision is now accepted and ready to land.Nov 20 2017, 4:30 PM
sanjoy accepted this revision.Nov 20 2017, 9:22 PM

lgtm too

This revision was automatically updated to reflect the committed changes.