Enable PDB generation with lld in asan and cfi tests on Windows.

[pcc]

Summary

PDB emission now works well enough that we can rely on it for these
tests to pass.

[rnk]

lgtm

compiler-rt/test/asan/TestCases/Windows/fuse-lld.cc

 // If we have LLD, see that things more or less work.
 //
 // REQUIRES: lld-available
 //
-// FIXME: Use -fuse-ld=lld after the old COFF linker is removed.
-// FIXME: Test will fail until we add flags for requesting dwarf or cv.
-// RUNX: %clangxx_asan -O2 %s -o %t.exe -fuse-ld=lld -Wl,-debug
-// RUN: %clangxx_asan -c -O2 %s -o %t.o -g -gdwarf
-// RUN: lld-link %t.o -out:%t.exe -debug -nopdb -defaultlib:libcmt %asan_lib %asan_cxx_lib
+// RUN: %clangxx_asan -O2 %s -o %t.exe -g -gcodeview -fuse-ld=lld -Wl,-debug
 // RUN: not %run %t.exe 2>&1 | FileCheck %s
 
 #include <stdlib.h>
 
 int main() {
   char *x = (char*)malloc(10 * sizeof(char));
   free(x);
   return x[5];
   // CHECK: heap-use-after-free
   // CHECK: free
   // CHECK: main{{.*}}fuse-lld.cc:[[@LINE-4]]:3
   // CHECK: malloc
   // CHECK: main{{.*}}fuse-lld.cc:[[@LINE-7]]:20
 }

compiler-rt/test/cfi/lit.cfg

if config.lto_supported:
   if config.android:
     dso += '-include ' + config.test_source_root + '/cross-dso/util/cfi_stubs.h '
   config.substitutions.append((r"%clang_cfi ", clang_cfi + non_dso))
   config.substitutions.append((r"%clangxx_cfi ", clang_cfi + cxx + non_dso))
   config.substitutions.append((r"%clang_cfi_diag ", clang_cfi + non_dso + diag))
   config.substitutions.append((r"%clangxx_cfi_diag ", clang_cfi + cxx + non_dso + diag))
   config.substitutions.append((r"%clangxx_cfi_dso ", clang_cfi + cxx + dso))
   config.substitutions.append((r"%clangxx_cfi_dso_diag ", clang_cfi + cxx + dso + diag))
+  config.substitutions.append((r"%debug_info_flags", ' '.join(config.debug_info_flags)))
 else:
   config.unsupported = True
 
 if config.default_sanitizer_opts:
   config.environment['UBSAN_OPTIONS'] = ':'.join(config.default_sanitizer_opts)
 
 if lit_config.params.get('check_supported', None) and config.unsupported:
   raise BaseException("Tests unsupported")

compiler-rt/test/cfi/stats.cpp

-// RUN: %clangxx_cfi -g -fsanitize-stats -o %t %s
+// RUN: %clangxx_cfi %debug_info_flags -fsanitize-stats -o %t %s
 // RUN: env SANITIZER_STATS_PATH=%t.stats %run %t
 // RUN: sanstats %t.stats | FileCheck %s
 
 // FIXME: We currently emit the wrong debug info under devirtualization.
 // UNSUPPORTED: devirt
 
 // FIXME: %t.stats must be transferred from device to host for this to work on Android.
 // XFAIL: android

compiler-rt/test/lit.common.cfg

elif config.host_os == 'Linux' and is_linux_lto_supported():
   config.lto_launch = []
   if config.use_lld:
     config.lto_flags = ["-fuse-ld=lld"]
   else:
     config.lto_flags = ["-fuse-ld=gold"]
 elif config.host_os == 'Windows' and is_windows_lto_supported():
   config.lto_supported = True
   config.lto_launch = []
-  # FIXME: Remove -nopdb when PDB writing is ready.
-  config.lto_flags = ["-fuse-ld=lld -Wl,-nopdb"]
+  config.lto_flags = ["-fuse-ld=lld"]
 else:
   config.lto_supported = False
 
 if config.lto_supported:
   config.available_features.add('lto')
   if config.use_thinlto:
     config.available_features.add('thinlto')
     config.lto_flags += ["-flto=thin"]