Do not use default arguments of DataLayout::getPointer*. NFC

[MaskRay]

Summary

There are "FIXME"s in include/llvm/IR/DataLayout.h to remove the default arguments.

[bjope]

source/Expression/IRInterpreter.cpp

389 ↗

(On Diff #122969)

I like that you are trying to get rid of the default arguments to those methods, because I think that there are some "errors" lurking around when using the default arguments. And that is probably the reason for the FIXME in DataLayout (it is about going through the code and making sure we pass the _correct_ address space at every call to those methods).

However, when I read your code here it is hard for me to tell if you have analyzed that it is correct to always use address space zero here. It is still a "magic" 0 in the argument.

Could you perhaps write this as:

// Address space is always 0 here because .... 
unsigned AS = 0;
return Malloc(m_target_data.getPointerSize(AS),
              m_target_data.getPointerPrefAlignment(AS));

to give the constant a name, and preferably also include a comment describing why it should be zero.

[MaskRay]

Remove MallocPointer because it turns out it is not used.

[MaskRay]

Friendly ping...

[clayborg]

I don't believe I am the right guy to review this.

[zturner]

If you're just removing dead code, then lgtm

lldb/trunk/source/Expression/IRInterpreter.cpp

lldb::addr_t Malloc(size_t size, uint8_t byte_alignment) {
 
     if (ret < m_frame_process_address)
       return LLDB_INVALID_ADDRESS;
 
     m_stack_pointer = ret;
     return ret;
   }
 
-  lldb::addr_t MallocPointer() {
-    return Malloc(m_target_data.getPointerSize(),
-                  m_target_data.getPointerPrefAlignment());
-  }
-
   lldb::addr_t Malloc(llvm::Type *type) {
     lldb_private::Status alloc_error;
 
     return Malloc(m_target_data.getTypeAllocSize(type),
                   m_target_data.getPrefTypeAlignment(type));
   }
 
   std::string PrintData(lldb::addr_t addr, llvm::Type *type) {