This is an archive of the discontinued LLVM Phabricator instance.

[DeclPrinter] Honor TerseOutput for constructors
ClosedPublic

Authored by nik on Nov 13 2017, 7:15 AM.

Event Timeline

nik created this revision.Nov 13 2017, 7:15 AM
nik updated this revision to Diff 122805.Nov 14 2017, 3:06 AM
  • [DeclPrinter] Allow printing fully qualified name of function declaration
nik updated this revision to Diff 122806.Nov 14 2017, 3:09 AM

Ops, restored to previous state.

nik updated this revision to Diff 122809.Nov 14 2017, 3:15 AM

Try to restore, II.

nik added a comment.Nov 14 2017, 3:26 AM

Sorry for the noise, I'm just doing my first steps with "arc diff".

I've managed to restore this - please review or add more appropriate reviewers.

arphaman accepted this revision.Nov 14 2017, 12:56 PM

LGTM

lib/AST/DeclPrinter.cpp
618

NIT: This function is getting a bit unwieldy. You might want to extract the initializer printing code into a new function in a pre/post commit.

This revision is now accepted and ready to land.Nov 14 2017, 12:56 PM
nik added a comment.Nov 15 2017, 1:02 AM

Thanks for the fast review! :)

Please land/submit this for me as I don't have permissions for this.

lib/AST/DeclPrinter.cpp
618

Will do.

Thanks. Sure, I will commit the patches today.

FYI, please remember to CC cfe-commits for your future patches.

This revision was automatically updated to reflect the committed changes.
nik added a comment.Nov 16 2017, 12:24 AM

Thanks Alex!

FYI, please remember to CC cfe-commits for your future patches.

Oh, OK. I guess I somehow assumed arc diff would took care of that.