This is an archive of the discontinued LLVM Phabricator instance.

[support] allocate exact size required for mapping in Support/Windws/Path.inc
ClosedPublic

Authored by inglorion on Nov 9 2017, 3:56 PM.

Details

Summary

zturner suggested that mapped_file_region::init() on Windows seems to
create mappings that are larger than they need to be: Offset+Size
instead of Size. Indeed, that appears to be the case. I confirmed that
tests pass with mappings of just Size bytes, and fail with Size-1
bytes, suggesting that Size is indeed the correct value.

Event Timeline

inglorion created this revision.Nov 9 2017, 3:56 PM
zturner accepted this revision.Nov 9 2017, 3:58 PM

yay, huge space gains ftw.

This revision is now accepted and ready to land.Nov 9 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.