[clang] [python] [tests] Update priority values in code completion test

[mgorny]

Summary

The priority for destructors and operators was reduced in rL314019.
Adjust the values used in the test appropriately to fix the test
failure.

[ilya-biryukov]

LGTM.

Can we run those tests as part of check-all cmake target or setup a buildbot that runs those? Seems surprising it went unnoticed for so long.

[mgorny]

In D39838#920399, @ilya-biryukov wrote:

LGTM.

Can we run those tests as part of check-all cmake target or setup a buildbot that runs those? Seems surprising it went unnoticed for so long.

I was thinking of that but I think it'd be nice to find someone who knows them better. I know they're loading libclang.so dynamically somehow, and I'm not really sure how to make sure that they're going to test the right library. On Gentoo we run the tests after installing clang to the system.

cfe/trunk/bindings/python/tests/cindex/test_code_completion.py

expected = [
       "{'P', TypedText} | {'::', Text} || Priority: 75 || Availability: Available || Brief comment: None",
       "{'Q', TypedText} | {'::', Text} || Priority: 75 || Availability: Available || Brief comment: None"
     ]
     check_completion_results(cr, expected)
 
     cr = tu.codeComplete('fake.cpp', 13, 5, unsaved_files=files)
     expected = [
         "{'P', TypedText} | {'::', Text} || Priority: 75 || Availability: Available || Brief comment: None",
-        "{'P &', ResultType} | {'operator=', TypedText} | {'(', LeftParen} | {'const P &', Placeholder} | {')', RightParen} || Priority: 34 || Availability: Available || Brief comment: None",
+        "{'P &', ResultType} | {'operator=', TypedText} | {'(', LeftParen} | {'const P &', Placeholder} | {')', RightParen} || Priority: 79 || Availability: Available || Brief comment: None",
         "{'int', ResultType} | {'member', TypedText} || Priority: 35 || Availability: NotAccessible || Brief comment: None",
-        "{'void', ResultType} | {'~P', TypedText} | {'(', LeftParen} | {')', RightParen} || Priority: 34 || Availability: Available || Brief comment: None"
+        "{'void', ResultType} | {'~P', TypedText} | {'(', LeftParen} | {')', RightParen} || Priority: 79 || Availability: Available || Brief comment: None"
     ]
     check_completion_results(cr, expected)