Page MenuHomePhabricator

DAG: Preserve nuw when reassociating adds
Needs ReviewPublic

Authored by arsenm on Nov 5 2017, 3:49 PM.

Details

Summary

DAG version of subset of D39417

Diff Detail

Event Timeline

arsenm created this revision.Nov 5 2017, 3:49 PM
davide requested changes to this revision.Nov 5 2017, 5:24 PM
davide added a subscriber: davide.

testcase?

This revision now requires changes to proceed.Nov 5 2017, 5:24 PM
arsenm added a comment.Nov 6 2017, 7:43 AM

testcase?

Test is hard for this short of testing debug info, which is fragile. This prevents some regressions in a future AMDGPU commit

arsenm updated this revision to Diff 121737.Nov 6 2017, 7:43 AM
arsenm edited edge metadata.

Handle special case reassociate through shl/add

testcase?

Test is hard for this short of testing debug info, which is fragile. This prevents some regressions in a future AMDGPU commit

CC:ing Adrian for thoughts.

aprantl edited edge metadata.Nov 6 2017, 11:22 AM

If it does break a subsequent commit, could you commit that first, and then apply this to fix the regressions introduced by the other commit?

arsenm added a comment.Nov 6 2017, 3:22 PM

If it does break a subsequent commit, could you commit that first, and then apply this to fix the regressions introduced by the other commit?

This would be the 3rd time I've had to touch all of the tests impacted by the, and each time it's been a pain. That patch adds folding an addressing mode that doesn't support overflows, so directly checks NUW. Once that's in it should be more straightforward to write the tests with these situations directly feeding into the address expression.