Page MenuHomePhabricator

ELF: Remove DefinedCommon.
ClosedPublic

Authored by pcc on Nov 5 2017, 2:02 PM.

Details

Summary

Common symbols are now represented with a DefinedRegular that points
to a BssSection, even during symbol resolution.

Depends on D39394

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Nov 5 2017, 2:02 PM
ruiu accepted this revision.Nov 5 2017, 2:32 PM

LGTM

Very nice improvement! I haven't thought of this approach before, but this totally makes sense to me.

If you need my patch, please commit it.

lld/ELF/InputSection.h
57 ↗(On Diff #121664)

Can you add this to InputSection?

This revision is now accepted and ready to land.Nov 5 2017, 2:32 PM
pcc added inline comments.Nov 5 2017, 8:29 PM
lld/ELF/InputSection.h
57 ↗(On Diff #121664)

Do you mean InputSectionBase? I put it here so that it would pack with the other bitfield.

This revision was automatically updated to reflect the committed changes.