This is an archive of the discontinued LLVM Phabricator instance.

Differential D39615

[CodeGen] add remquo to list of recognized library calls
ClosedPublic

Authored by spatel on Nov 3 2017, 1:16 PM.

Details

Reviewers
efriedma
hfinkel
craig.topper
Commits
rGc91975807568: [CodeGen] add remquo to list of recognized library calls
rC317407: [CodeGen] add remquo to list of recognized library calls
rL317407: [CodeGen] add remquo to list of recognized library calls
Summary

I assume this is just an oversight because we already do recognize __builtin_remquo() with the same signature.

http://en.cppreference.com/w/c/numeric/math/remquo
http://pubs.opengroup.org/onlinepubs/9699919799/functions/remquo.html

Diff Detail

Event Timeline

spatel created this revision.Nov 3 2017, 1:16 PM
Herald added a subscriber: mcrosier. · View Herald TranscriptNov 3 2017, 1:16 PM
efriedma accepted this revision.Nov 3 2017, 3:57 PM

LGTM

This revision is now accepted and ready to land.Nov 3 2017, 3:57 PM
Closed by commit rL317407: [CodeGen] add remquo to list of recognized library calls (authored by spatel). · Explain WhyNov 4 2017, 8:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
clang/
Basic/
4 lines
test/
CodeGen/
12 lines

Diff 121536

include/clang/Basic/Builtins.def

Show First 20 Lines • Show All 1,156 Lines • ▼ Show 20 Lines
LIBBUILTIN(nexttoward, "ddLd", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(nexttoward, "ddLd", "fne", "math.h", ALL_LANGUAGES)
LIBBUILTIN(nexttowardf, "ffLd", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(nexttowardf, "ffLd", "fne", "math.h", ALL_LANGUAGES)
LIBBUILTIN(nexttowardl, "LdLdLd", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(nexttowardl, "LdLdLd", "fne", "math.h", ALL_LANGUAGES)
LIBBUILTIN(remainder, "ddd", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(remainder, "ddd", "fne", "math.h", ALL_LANGUAGES)
LIBBUILTIN(remainderf, "fff", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(remainderf, "fff", "fne", "math.h", ALL_LANGUAGES)
LIBBUILTIN(remainderl, "LdLdLd", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(remainderl, "LdLdLd", "fne", "math.h", ALL_LANGUAGES)
LIBBUILTIN(remquo, "dddi*", "fn", "math.h", ALL_LANGUAGES)
LIBBUILTIN(remquof, "fffi*", "fn", "math.h", ALL_LANGUAGES)
LIBBUILTIN(remquol, "LdLdLdi*", "fn", "math.h", ALL_LANGUAGES)
LIBBUILTIN(rint, "dd", "fnc", "math.h", ALL_LANGUAGES) LIBBUILTIN(rint, "dd", "fnc", "math.h", ALL_LANGUAGES)
LIBBUILTIN(rintf, "ff", "fnc", "math.h", ALL_LANGUAGES) LIBBUILTIN(rintf, "ff", "fnc", "math.h", ALL_LANGUAGES)
LIBBUILTIN(rintl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) LIBBUILTIN(rintl, "LdLd", "fnc", "math.h", ALL_LANGUAGES)
LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES)
LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES)
LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES)
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines

test/CodeGen/libcalls-errno.c

Show First 20 Lines • Show All 412 Lines • ▼ Show 20 Lines
// NO__ERRNO: declare double @remainder(double, double) [[READNONE]] // NO__ERRNO: declare double @remainder(double, double) [[READNONE]]
// NO__ERRNO: declare float @remainderf(float, float) [[READNONE]] // NO__ERRNO: declare float @remainderf(float, float) [[READNONE]]
// NO__ERRNO: declare x86_fp80 @remainderl(x86_fp80, x86_fp80) [[READNONE]] // NO__ERRNO: declare x86_fp80 @remainderl(x86_fp80, x86_fp80) [[READNONE]]
// HAS_ERRNO: declare double @remainder(double, double) [[NOT_READNONE]] // HAS_ERRNO: declare double @remainder(double, double) [[NOT_READNONE]]
// HAS_ERRNO: declare float @remainderf(float, float) [[NOT_READNONE]] // HAS_ERRNO: declare float @remainderf(float, float) [[NOT_READNONE]]
// HAS_ERRNO: declare x86_fp80 @remainderl(x86_fp80, x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare x86_fp80 @remainderl(x86_fp80, x86_fp80) [[NOT_READNONE]]
// remquo(f,f,i); remquof(f,f,i); remquol(f,f,i);
// FIXME: remquo is not recognized as a mathlib call.
// // NO__ERRNO: declare double @remquo(double, double, i32*) [[NOT_READNONE]]
// remquo(f,f,i); remquof(f,f,i); remquol(f,f,i); // NO__ERRNO: declare float @remquof(float, float, i32*) [[NOT_READNONE]]
// NO__ERRNO: declare x86_fp80 @remquol(x86_fp80, x86_fp80, i32*) [[NOT_READNONE]]
// HAS_ERRNO: declare double @remquo(double, double, i32*) [[NOT_READNONE]]
// HAS_ERRNO: declare float @remquof(float, float, i32*) [[NOT_READNONE]]
// HAS_ERRNO: declare x86_fp80 @remquol(x86_fp80, x86_fp80, i32*) [[NOT_READNONE]]
rint(f); rintf(f); rintl(f); rint(f); rintf(f); rintl(f);
// NO__ERRNO: declare double @rint(double) [[READNONE]] // NO__ERRNO: declare double @rint(double) [[READNONE]]
// NO__ERRNO: declare float @rintf(float) [[READNONE]] // NO__ERRNO: declare float @rintf(float) [[READNONE]]
// NO__ERRNO: declare x86_fp80 @rintl(x86_fp80) [[READNONE]] // NO__ERRNO: declare x86_fp80 @rintl(x86_fp80) [[READNONE]]
// HAS_ERRNO: declare double @rint(double) [[READNONE]] // HAS_ERRNO: declare double @rint(double) [[READNONE]]
// HAS_ERRNO: declare float @rintf(float) [[READNONE]] // HAS_ERRNO: declare float @rintf(float) [[READNONE]]
▲ Show 20 Lines • Show All 300 Lines • Show Last 20 Lines