This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] [NFC] very minor ExprEngineC refactoring
ClosedPublic

Authored by george.karpenkov on Nov 2 2017, 3:52 PM.

Reviewers

Commits

LGTM. It is a nice cleanup.

This revision is now accepted and ready to land.Nov 2 2017, 5:35 PM

@dcoughlin thanks for accepting quickly, actually the whole file has a very large amount of duplicated code, but I guess we can't do it right now.

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

StaticAnalyzer/

Core/

6 lines

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines	if (!B->isAssignmentOp()) {
// sure that the members of temporaries have a valid 'this' pointer for		// sure that the members of temporaries have a valid 'this' pointer for
// other checks.		// other checks.
if (B->getOpcode() == BO_PtrMemD)		if (B->getOpcode() == BO_PtrMemD)
state = createTemporaryRegionIfNeeded(state, LCtx, LHS);		state = createTemporaryRegionIfNeeded(state, LCtx, LHS);

// Process non-assignments except commas or short-circuited		// Process non-assignments except commas or short-circuited
// logical expressions (LAnd and LOr).		// logical expressions (LAnd and LOr).
SVal Result = evalBinOp(state, Op, LeftV, RightV, B->getType());		SVal Result = evalBinOp(state, Op, LeftV, RightV, B->getType());
if (Result.isUnknown()) {		if (!Result.isUnknown()) {
Bldr.generateNode(B, *it, state);		state = state->BindExpr(B, LCtx, Result);
continue;
}		}

state = state->BindExpr(B, LCtx, Result);
Bldr.generateNode(B, *it, state);		Bldr.generateNode(B, *it, state);
continue;		continue;
}		}

assert (B->isCompoundAssignmentOp());		assert (B->isCompoundAssignmentOp());

switch (Op) {		switch (Op) {
default:		default:
▲ Show 20 Lines • Show All 986 Lines • Show Last 20 Lines