This is an archive of the discontinued LLVM Phabricator instance.

Differential D39523

[clang-reorder-fields] Switch to add_clang_tool
ClosedPublic

Authored by smeenai on Nov 1 2017, 5:52 PM.

Details

Reviewers
alexander-shaposhnikov
beanz
compnerd
Commits
rGc40419d94b1d: [clang-reorder-fields] Switch to add_clang_tool
rCTE317149: [clang-reorder-fields] Switch to add_clang_tool
rL317149: [clang-reorder-fields] Switch to add_clang_tool
Summary

add_clang_tool invokes add_clang_executable internally, but it also
takes care of setting up the install rule. It also adds an install-*
build target, which is required for LLVM_DISTRIBUTION_COMPONENTS.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai created this revision.Nov 1 2017, 5:52 PM
Harbormaster completed remote builds in B11736: Diff 121219.Nov 1 2017, 5:52 PM
Herald added a subscriber: mgorny. · View Herald TranscriptNov 1 2017, 5:52 PM
compnerd accepted this revision.Nov 1 2017, 5:54 PM
This revision is now accepted and ready to land.Nov 1 2017, 5:54 PM
alexander-shaposhnikov accepted this revision.Nov 1 2017, 6:09 PM
Closed by commit rL317149: [clang-reorder-fields] Switch to add_clang_tool (authored by smeenai). · Explain WhyNov 1 2017, 6:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tools-extra/
trunk/
clang-reorder-fields/
tool/
4 lines

Diff 121221

clang-tools-extra/trunk/clang-reorder-fields/tool/CMakeLists.txt

add_clang_executable(clang-reorder-fields ClangReorderFields.cpp) add_clang_tool(clang-reorder-fields ClangReorderFields.cpp)
target_link_libraries(clang-reorder-fields target_link_libraries(clang-reorder-fields
clangBasic clangBasic
clangFrontend clangFrontend
clangReorderFields clangReorderFields
clangRewrite clangRewrite
clangTooling clangTooling
clangToolingCore clangToolingCore
) )
install(TARGETS clang-reorder-fields RUNTIME DESTINATION bin)