This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][CMake] Fix libc++ build when no LLVM source tree is available.
AbandonedPublic

Authored by vsapsai on Nov 1 2017, 4:38 PM.

Details

Summary

Fixes error

CMake Error at test/CMakeLists.txt:52 (configure_lit_site_cfg):
Unknown CMake command "configure_lit_site_cfg".

configure_lit_site_cfg is defined in AddLLVM module and not available
without LLVM source tree. Revert back to configure_file (reverts part of
r313643). It is possible as libcxx/test/lit.site.cfg.in doesn't use
latest lit capabilities.

Tested with

  • in-tree libcxx - no change in generated lit.site.cfg and running tests;
  • standalone libcxx with lit checked out next to it - no CMake errors.

If there are other tricky configurations worth testing, let me know.

rdar://problem/35303262

Event Timeline

vsapsai created this revision.Nov 1 2017, 4:38 PM
vsapsai abandoned this revision.Nov 2 2017, 4:43 PM

Fixed by changing libcxx build configuration, no CMake change required.