This is an archive of the discontinued LLVM Phabricator instance.

Paths

Allow SysV-i386 ABI on everything other than Apple targets
ClosedPublic

Authored by sas on Oct 26 2017, 9:48 AM.

Reviewers

clayborg
emaste

Commits

Summary

This matches other SysV ABIs that are different on Apple and non-Apple targets,
like ABISysV_arm.cpp for instance.

Build Status

Buildable 11525
Build 11525: arc lint + arc unit

This revision is now accepted and ready to land.Oct 26 2017, 10:02 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Plugins/

ABI/

SysV-i386/

11 lines

	Show First 20 Lines • Show All 199 Lines • ▼ Show 20 Lines

	//------------------------------------------------------------------			//------------------------------------------------------------------
	// Static Functions			// Static Functions
	//------------------------------------------------------------------			//------------------------------------------------------------------

	ABISP			ABISP
	ABISysV_i386::CreateInstance(lldb::ProcessSP process_sp, const ArchSpec &arch) {			ABISysV_i386::CreateInstance(lldb::ProcessSP process_sp, const ArchSpec &arch) {
	static ABISP g_abi_sp;			static ABISP g_abi_sp;
	if ((arch.GetTriple().getArch() == llvm::Triple::x86) &&			if (arch.GetTriple().getVendor() != llvm::Triple::Apple) {
	(arch.GetTriple().isOSLinux() \|\| arch.GetTriple().isOSFreeBSD())) {			if (arch.GetTriple().getArch() == llvm::Triple::x86) {
	if (!g_abi_sp)			if (!g_abi_sp)
	g_abi_sp.reset(new ABISysV_i386(process_sp));			g_abi_sp.reset(new ABISysV_i386(process_sp));
	return g_abi_sp;			return g_abi_sp;
	}			}
				}
	return ABISP();			return ABISP();
	}			}

	bool ABISysV_i386::PrepareTrivialCall(Thread &thread, addr_t sp,			bool ABISysV_i386::PrepareTrivialCall(Thread &thread, addr_t sp,
	addr_t func_addr, addr_t return_addr,			addr_t func_addr, addr_t return_addr,
	llvm::ArrayRef<addr_t> args) const {			llvm::ArrayRef<addr_t> args) const {
	RegisterContext *reg_ctx = thread.GetRegisterContext().get();			RegisterContext *reg_ctx = thread.GetRegisterContext().get();

	▲ Show 20 Lines • Show All 638 Lines • Show Last 20 Lines