This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Restrict resource file usage to Windows build hosts
ClosedPublic

Authored by smeenai on Oct 24 2017, 5:22 PM.

Details

Summary

Resource file compilation requires a working resource compiler.
Unfortunately, llvm-rc isn't quite there yet [1], and cmake's rc
invocation only works on Windows [2]. Until both those issues are
addressed, disable resource file usage on non-Windows build hosts, to
unblock Windows cross-compilation. This is also consistent with the
existing comment, which says "If *on Windows* and building with MSVC".

[1] http://lists.llvm.org/pipermail/llvm-dev/2017-October/118433.html
[2] https://public.kitware.com/pipermail/cmake/2017-October/066441.html

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai created this revision.Oct 24 2017, 5:22 PM
compnerd accepted this revision.Oct 24 2017, 8:36 PM
This revision is now accepted and ready to land.Oct 24 2017, 8:36 PM
rnk accepted this revision.Oct 25 2017, 10:05 AM
This revision was automatically updated to reflect the committed changes.