This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Add missing checks for register number
ClosedPublic

Authored by mstorsjo on Oct 23 2017, 2:40 PM.

Details

Summary

Most other cases that touch savedRegisters[reg] have got this check, but these three seemed to lack it.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 23 2017, 2:40 PM
rnk accepted this revision.Oct 23 2017, 4:17 PM

lgtm

This revision is now accepted and ready to land.Oct 23 2017, 4:17 PM
compnerd accepted this revision.Oct 23 2017, 11:13 PM

I'd say out of range rather than too big.

This revision was automatically updated to reflect the committed changes.

I'd say out of range rather than too big.

Ok, pushing with the message changed to out of range, and actually printing the value.