This is an archive of the discontinued LLVM Phabricator instance.

Differential D39164

[utils] Support -mtriple=powerpc64
ClosedPublic

Authored by MaskRay on Oct 22 2017, 12:16 AM.

Details

Reviewers
spatel
chandlerc
Commits
rGdc168722daa8: [utils] Support -mtriple=powerpc64
rL316297: [utils] Support -mtriple=powerpc64
Summary

test/CodeGen/PowerPC/pr33093.ll uses both powerpc64 (big-endian) and powerpc64le while the former was unsupported.

Diff Detail

Event Timeline

MaskRay created this revision.Oct 22 2017, 12:16 AM
Herald added a subscriber: nemanjai. · View Herald TranscriptOct 22 2017, 12:16 AM
Harbormaster completed remote builds in B11362: Diff 119777.Oct 22 2017, 12:16 AM
MaskRay updated this revision to Diff 119778.Oct 22 2017, 12:17 AM

no

Harbormaster completed remote builds in B11363: Diff 119778.Oct 22 2017, 12:17 AM
MaskRay added reviewers: spatel, chandlerc.Oct 22 2017, 12:19 AM
spatel accepted this revision.Oct 22 2017, 9:52 AM

LGTM.

This revision is now accepted and ready to land.Oct 22 2017, 9:52 AM
Closed by commit rL316297: [utils] Support -mtriple=powerpc64 (authored by MaskRay). · Explain WhyOct 22 2017, 11:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
utils/
5 lines

Diff 119777

utils/update_llc_test_checks.py

Show First 20 Lines • Show All 116 Lines • ▼ Show 20 Linesdef scrub_asm_arm_eabi(asm):
# Expand the tabs used for indentation. # Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2) asm = string.expandtabs(asm, 2)
# Strip kill operands inserted into the asm. # Strip kill operands inserted into the asm.
asm = SCRUB_KILL_COMMENT_RE.sub('', asm) asm = SCRUB_KILL_COMMENT_RE.sub('', asm)
# Strip trailing whitespace. # Strip trailing whitespace.
asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm) asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
return asm return asm
def scrub_asm_powerpc64le(asm): def scrub_asm_powerpc64(asm):
# Scrub runs of whitespace out of the assembly, but leave the leading # Scrub runs of whitespace out of the assembly, but leave the leading
# whitespace in place. # whitespace in place.
asm = SCRUB_WHITESPACE_RE.sub(r' ', asm) asm = SCRUB_WHITESPACE_RE.sub(r' ', asm)
# Expand the tabs used for indentation. # Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2) asm = string.expandtabs(asm, 2)
# Stripe unimportant comments # Stripe unimportant comments
asm = SCRUB_LOOP_COMMENT_RE.sub(r'', asm) asm = SCRUB_LOOP_COMMENT_RE.sub(r'', asm)
# Strip trailing whitespace. # Strip trailing whitespace.
Show All 19 Lines target_handlers = {
'i686': (scrub_asm_x86, ASM_FUNCTION_X86_RE), 'i686': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE), 'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE), 'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE), 'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),
'arm-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE), 'arm-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'thumb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE), 'thumb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'thumbv8-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE), 'thumbv8-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'armeb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE), 'armeb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'powerpc64le': (scrub_asm_powerpc64le, ASM_FUNCTION_PPC_RE), 'powerpc64': (scrub_asm_powerpc64, ASM_FUNCTION_PPC_RE),
'powerpc64le': (scrub_asm_powerpc64, ASM_FUNCTION_PPC_RE),
's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE), 's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE),
} }
handlers = None handlers = None
for prefix, s in target_handlers.items(): for prefix, s in target_handlers.items():
if triple.startswith(prefix): if triple.startswith(prefix):
handlers = s handlers = s
break break
else: else:
▲ Show 20 Lines • Show All 214 Lines • Show Last 20 Lines