This is an archive of the discontinued LLVM Phabricator instance.

Differential D39157

fix typo in a CMake SANITIZER_CAN_USE_CXXABI variable initial definition
ClosedPublic

Authored by pelikan on Oct 21 2017, 2:05 AM.

Details

Reviewers
pcc
Jim
Commits
rGdd4c999c2316: fix typo in a CMake SANITIZER_CAN_USE_CXXABI variable initial definition
Summary

The current variable name isn't used anywhere else, which indicates it's
a typo. Let's fix it before someone copy+pastes it somewhere else.

Diff Detail

Event Timeline

pelikan created this revision.Oct 21 2017, 2:05 AM
Herald added a subscriber: mgorny. · View Herald TranscriptOct 21 2017, 2:05 AM
Harbormaster completed remote builds in B11357: Diff 119745.Oct 21 2017, 2:07 AM
Jim requested changes to this revision.Dec 11 2019, 11:15 PM
Jim added a subscriber: Jim.

This needs rebased.

This revision now requires changes to proceed.Dec 11 2019, 11:15 PM
Jim updated this revision to Diff 336749.Apr 11 2021, 10:57 PM

Rebase

Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2021, 10:57 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Jim accepted this revision.Apr 11 2021, 10:59 PM

It is simply a typo. Accept and land it directly.

This revision is now accepted and ready to land.Apr 11 2021, 10:59 PM
This revision was landed with ongoing or failed builds.Apr 11 2021, 11:02 PM
Closed by commit rGdd4c999c2316: fix typo in a CMake SANITIZER_CAN_USE_CXXABI variable initial definition (authored by Jim). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jim added a commit: rGdd4c999c2316: fix typo in a CMake SANITIZER_CAN_USE_CXXABI variable initial definition.
Harbormaster completed remote builds in B98215: Diff 336749.Apr 11 2021, 11:39 PM

Revision Contents

PathSize
2 lines

Diff 119745

CMakeLists.txt

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Linesif(APPLE AND SANITIZER_MIN_OSX_VERSION AND SANITIZER_MIN_OSX_VERSION VERSION_LESS "10.9")
# libc++/libc++abi. # libc++/libc++abi.
set(cxxabi_supported OFF) set(cxxabi_supported OFF)
else() else()
set(cxxabi_supported ON) set(cxxabi_supported ON)
endif() endif()
option(SANITIZER_ALLOW_CXXABI "Allow use of C++ ABI details in ubsan" ON) option(SANITIZER_ALLOW_CXXABI "Allow use of C++ ABI details in ubsan" ON)
set(SANITIZE_CAN_USE_CXXABI OFF) set(SANITIZER_CAN_USE_CXXABI OFF)
if (cxxabi_supported AND SANITIZER_ALLOW_CXXABI) if (cxxabi_supported AND SANITIZER_ALLOW_CXXABI)
set(SANITIZER_CAN_USE_CXXABI ON) set(SANITIZER_CAN_USE_CXXABI ON)
endif() endif()
pythonize_bool(SANITIZER_CAN_USE_CXXABI) pythonize_bool(SANITIZER_CAN_USE_CXXABI)
set(SANITIZER_CXX_ABI "default" CACHE STRING set(SANITIZER_CXX_ABI "default" CACHE STRING
"Specify C++ ABI library to use.") "Specify C++ ABI library to use.")
set(CXXABIS none default libcxxabi libstdc++ libc++) set(CXXABIS none default libcxxabi libstdc++ libc++)
▲ Show 20 Lines • Show All 250 Lines • Show Last 20 Lines