This is an archive of the discontinued LLVM Phabricator instance.

[X86] Teach the assembly parser to warn on duplicate registers in gather instructions.
ClosedPublic

Authored by craig.topper on Oct 18 2017, 4:03 PM.

Diff Detail

Event Timeline

craig.topper created this revision.Oct 18 2017, 4:03 PM
craig.topper retitled this revision from [X86] Teach the assembly parser to warning on duplicate registers in gather instructions. to [X86] Teach the assembly parser to warn on duplicate registers in gather instructions..
craig.topper added a subscriber: llvm-commits.
zvi added a reviewer: coby.Oct 19 2017, 4:26 AM
zvi edited edge metadata.Oct 19 2017, 4:32 AM

LGTM

RKSimon edited edge metadata.Oct 19 2017, 7:32 AM

Should we test for cases where the index register is a different size to the mask/result? Like _mm256_i32gather_epi64?

Add additional tests

RKSimon accepted this revision.Oct 26 2017, 3:40 AM

LGTM - thanks

This revision is now accepted and ready to land.Oct 26 2017, 3:40 AM
This revision was automatically updated to reflect the committed changes.