Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

coby (coby)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2016, 7:41 AM (378 w, 1 d)

Recent Activity

Dec 27 2017

coby committed rL321487: [x86][icelake][vbmi2].
[x86][icelake][vbmi2]
Dec 27 2017, 3:26 AM
coby committed rC321487: [x86][icelake][vbmi2].
[x86][icelake][vbmi2]
Dec 27 2017, 3:26 AM
coby closed D41557: [x86][icelake][vbmi2].
Dec 27 2017, 3:26 AM
coby committed rC321484: [x86][icelake][vnni].
[x86][icelake][vnni]
Dec 27 2017, 2:39 AM
coby committed rL321484: [x86][icelake][vnni].
[x86][icelake][vnni]
Dec 27 2017, 2:39 AM
coby closed D41558: [x86][icelake][vnni].
Dec 27 2017, 2:38 AM
coby committed rC321483: [x86][icelake][bitalg].
[x86][icelake][bitalg]
Dec 27 2017, 2:02 AM
coby committed rL321483: [x86][icelake][bitalg].
[x86][icelake][bitalg]
Dec 27 2017, 2:02 AM
coby closed D41564: [x86][icelake][bitalg].
Dec 27 2017, 2:02 AM
coby committed rL321482: [hotfix].
[hotfix]
Dec 27 2017, 1:23 AM
coby committed rC321482: [hotfix].
[hotfix]
Dec 27 2017, 1:23 AM
coby committed rC321480: [x86][icelake][vpclmulqdq].
[x86][icelake][vpclmulqdq]
Dec 27 2017, 1:01 AM
coby committed rL321480: [x86][icelake][vpclmulqdq].
[x86][icelake][vpclmulqdq]
Dec 27 2017, 1:01 AM
coby closed D41573: [x86][icelake][vpclmulqdq].
Dec 27 2017, 1:01 AM
coby closed D41583: [x86][icelake][vaes].

closed by commit rC321474 (rL321474)

Dec 27 2017, 12:39 AM
coby committed rC321477: [x86][icelake][gfni].
[x86][icelake][gfni]
Dec 27 2017, 12:38 AM
coby committed rL321477: [x86][icelake][gfni].
[x86][icelake][gfni]
Dec 27 2017, 12:38 AM
coby closed D41582: [x86][icelake][gfni].
Dec 27 2017, 12:38 AM
coby committed rC321474: [x86][icelake][vaes].
[x86][icelake][vaes]
Dec 27 2017, 12:19 AM
coby committed rL321474: [x86][icelake][vaes].
[x86][icelake][vaes]
Dec 27 2017, 12:18 AM

Dec 26 2017

coby updated the diff for D41583: [x86][icelake][vaes].

turning aes off forbids enabling vaes

Dec 26 2017, 12:21 PM
coby updated the diff for D41573: [x86][icelake][vpclmulqdq].

turning off pclmul forbids enabling vpclmulqdq

Dec 26 2017, 12:04 PM
coby added inline comments to D41573: [x86][icelake][vpclmulqdq].
Dec 26 2017, 11:22 AM
coby added inline comments to D41583: [x86][icelake][vaes].
Dec 26 2017, 9:47 AM
coby updated the diff for D41557: [x86][icelake][vbmi2].

tests

Dec 26 2017, 6:57 AM
coby updated the diff for D41557: [x86][icelake][vbmi2].

addressed comments

Dec 26 2017, 6:55 AM
coby added inline comments to D41557: [x86][icelake][vbmi2].
Dec 26 2017, 6:46 AM
coby created D41583: [x86][icelake][vaes].
Dec 26 2017, 5:35 AM
coby updated the diff for D41582: [x86][icelake][gfni].

add forgotten undef[s]

Dec 26 2017, 4:36 AM
coby created D41582: [x86][icelake][gfni].
Dec 26 2017, 4:06 AM

Dec 25 2017

coby updated the diff for D41573: [x86][icelake][vpclmulqdq].

removing guards to allow better diags

Dec 25 2017, 6:04 AM
coby created D41573: [x86][icelake][vpclmulqdq].
Dec 25 2017, 3:48 AM

Dec 24 2017

coby created D41564: [x86][icelake][bitalg].
Dec 24 2017, 6:38 AM

Dec 23 2017

coby retitled D41558: [x86][icelake][vnni] from [x86][icelake][vbmi2] to [x86][icelake][vnni].
Dec 23 2017, 11:47 PM
coby created D41558: [x86][icelake][vnni].
Dec 23 2017, 11:47 PM
coby updated the summary of D41557: [x86][icelake][vbmi2].
Dec 23 2017, 3:17 PM
coby created D41557: [x86][icelake][vbmi2].
Dec 23 2017, 2:47 PM

Nov 26 2017

coby committed rL318993: [x86][icelake]GFNI.
[x86][icelake]GFNI
Nov 26 2017, 1:38 AM
coby closed D40373: [x86][icelake]GFNI by committing rL318993: [x86][icelake]GFNI.
Nov 26 2017, 1:37 AM

Nov 25 2017

coby updated the diff for D40373: [x86][icelake]GFNI.

addressed Craig's comments

Nov 25 2017, 5:42 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 25 2017, 1:57 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 25 2017, 1:54 PM

Nov 23 2017

coby committed rL318904: [x86][icelake]BITALG.
[x86][icelake]BITALG
Nov 23 2017, 3:16 AM
coby closed D40222: [x86][icelake]BITALG by committing rL318904: [x86][icelake]BITALG.
Nov 23 2017, 3:16 AM
coby updated the diff for D40373: [x86][icelake]GFNI.

adopted changes proposed by Craig:
maskz variants are out in favor of explicit passing of the additive identity
BWI dependency is explicitly stated
GCC builtins counterparts are matched
+ nice formatting of feature recognition

Nov 23 2017, 1:55 AM

Nov 22 2017

coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 22 2017, 12:41 PM
coby updated the diff for D40222: [x86][icelake]BITALG.

adopted a stricter type constraints on bits shuffle node, as suggested by Craig

Nov 22 2017, 12:31 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 22 2017, 12:29 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 22 2017, 12:26 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 22 2017, 12:14 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Nov 22 2017, 12:11 PM
coby updated the summary of D40373: [x86][icelake]GFNI.
Nov 22 2017, 11:43 AM
coby created D40373: [x86][icelake]GFNI.
Nov 22 2017, 11:40 AM

Nov 21 2017

coby updated the diff for D40222: [x86][icelake]BITALG.

intrinsics support (3/3)

Nov 21 2017, 3:39 AM
coby committed rL318748: [x86][icelake]BITALG.
[x86][icelake]BITALG
Nov 21 2017, 2:33 AM
coby closed D40213: [x86][icelake]BITALG by committing rL318748: [x86][icelake]BITALG.
Nov 21 2017, 2:32 AM
coby committed rL318746: [x86][icelake]VNNI.
[x86][icelake]VNNI
Nov 21 2017, 2:07 AM
coby closed D40208: [x86][icelake]VNNI by committing rL318746: [x86][icelake]VNNI.
Nov 21 2017, 2:07 AM
coby committed rL318745: [x86][icelake]vbmi2.
[x86][icelake]vbmi2
Nov 21 2017, 1:49 AM
coby closed D40206: [x86][icelake]vbmi2 by committing rL318745: [x86][icelake]vbmi2.
Nov 21 2017, 1:49 AM
coby committed rL318741: [x86][icelake]vpclmulqdq introduction.
[x86][icelake]vpclmulqdq introduction
Nov 21 2017, 1:31 AM
coby closed D40101: [x86][icelake]vpclmulqdq introduction by committing rL318741: [x86][icelake]vpclmulqdq introduction.
Nov 21 2017, 1:30 AM
coby committed rL318740: [x86][icelake]VAES introduction.
[x86][icelake]VAES introduction
Nov 21 2017, 1:12 AM
coby closed D40078: [x86][icelake]VAES introduction by committing rL318740: [x86][icelake]VAES introduction.
Nov 21 2017, 1:11 AM
coby committed rL318739: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
[x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob
Nov 21 2017, 12:51 AM
coby closed D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob by committing rL318739: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Nov 21 2017, 12:51 AM

Nov 20 2017

coby updated the diff for D40213: [x86][icelake]BITALG.

added tzcnt tests
removed redundant blank line

Nov 20 2017, 6:38 AM
coby updated the diff for D40078: [x86][icelake]VAES introduction.

further refined selection of conflicting insns, as suggested by Craig (thanks)

Nov 20 2017, 5:28 AM
coby added a comment to D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.

Reid,
can you please have a look?

Nov 20 2017, 5:12 AM
coby updated the diff for D40078: [x86][icelake]VAES introduction.
Nov 20 2017, 5:06 AM
coby updated the diff for D40101: [x86][icelake]vpclmulqdq introduction.

further refined selection of conflicting insns, as suggested by Craig
added commutation tests, as suggested by Simon

Nov 20 2017, 4:35 AM
coby updated the diff for D40206: [x86][icelake]vbmi2.

Separated VBMI2's concatenate/shift insns implementation course from PMADD52

Nov 20 2017, 12:42 AM

Nov 19 2017

coby created D40222: [x86][icelake]BITALG.
Nov 19 2017, 1:05 AM

Nov 18 2017

coby created D40213: [x86][icelake]BITALG.
Nov 18 2017, 1:23 PM
coby created D40208: [x86][icelake]VNNI.
Nov 18 2017, 6:08 AM

Nov 17 2017

coby added reviewers for D40206: [x86][icelake]vbmi2: craig.topper, igorb.
Nov 17 2017, 10:14 PM
coby created D40206: [x86][icelake]vbmi2.
Nov 17 2017, 10:13 PM

Nov 15 2017

coby updated the diff for D40101: [x86][icelake]vpclmulqdq introduction.

refined VPCLMULQDQ recognition in favor of PCLMULQDQ

Nov 15 2017, 3:31 PM
coby created D40101: [x86][icelake]vpclmulqdq introduction.
Nov 15 2017, 2:33 PM
coby added inline comments to D40078: [x86][icelake]VAES introduction.
Nov 15 2017, 1:29 PM
coby updated the diff for D40078: [x86][icelake]VAES introduction.

addressed Craig's comments

Nov 15 2017, 12:33 PM
coby added inline comments to D40078: [x86][icelake]VAES introduction.
Nov 15 2017, 11:48 AM
coby added inline comments to D40078: [x86][icelake]VAES introduction.
Nov 15 2017, 11:33 AM
coby added a comment to D40078: [x86][icelake]VAES introduction.

intel syntax encoding test is to be added shortly

Nov 15 2017, 7:30 AM
coby created D40078: [x86][icelake]VAES introduction.
Nov 15 2017, 7:29 AM

Nov 2 2017

coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

@coby What is happening with this patch?

Nov 2 2017, 3:43 AM · Restricted Project

Oct 2 2017

coby committed rL314674: [AsmParser] Support GAS's .print directive.
[AsmParser] Support GAS's .print directive
Oct 2 2017, 7:38 AM
coby closed D38448: [AsmParser] Support GAS's .print directive by committing rL314674: [AsmParser] Support GAS's .print directive.
Oct 2 2017, 7:38 AM
coby added a comment to D38448: [AsmParser] Support GAS's .print directive.

thanks for the prompt review.
will address enum's values definition ordering upon the commit itself

Oct 2 2017, 6:44 AM

Oct 1 2017

coby added inline comments to D38448: [AsmParser] Support GAS's .print directive.
Oct 1 2017, 5:07 PM
coby updated the diff for D38448: [AsmParser] Support GAS's .print directive.
Oct 1 2017, 1:28 PM
coby created D38448: [AsmParser] Support GAS's .print directive.
Oct 1 2017, 1:23 PM
coby updated the diff for D37461: [X86][AsmParser] re-introduce 'offset' operator.

Minimal source changes - introduced 'new' enum values definitions as adapted on dependent change (D37412)
Added few more assembly level testing, as requested by @rnk
Minimized 'offset_operator.ll' test-case, and auto-updated it checks

Oct 1 2017, 7:45 AM · Restricted Project
coby added inline comments to D37466: D37461: fixups for existing InlineAsm tests + adding new ones.
Oct 1 2017, 5:45 AM
coby retitled D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob from [x86][inlin-asm] allow recognition of MPX regs inside ms inline-asm blob to [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Oct 1 2017, 5:15 AM
coby created D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Oct 1 2017, 5:15 AM

Sep 29 2017

coby committed rL314529: fixup, post rL314493.
fixup, post rL314493
Sep 29 2017, 9:06 AM
coby committed rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Sep 29 2017, 12:04 AM
coby closed D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions by committing rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
Sep 29 2017, 12:04 AM
coby committed rL314493: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Sep 29 2017, 12:04 AM