coby (coby)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2016, 7:41 AM (58 w, 1 d)

Recent Activity

Mon, Oct 2

coby committed rL314674: [AsmParser] Support GAS's .print directive.
[AsmParser] Support GAS's .print directive
Mon, Oct 2, 7:38 AM
coby closed D38448: [AsmParser] Support GAS's .print directive by committing rL314674: [AsmParser] Support GAS's .print directive.
Mon, Oct 2, 7:38 AM
coby added a comment to D38448: [AsmParser] Support GAS's .print directive.

thanks for the prompt review.
will address enum's values definition ordering upon the commit itself

Mon, Oct 2, 6:44 AM

Sun, Oct 1

coby added inline comments to D38448: [AsmParser] Support GAS's .print directive.
Sun, Oct 1, 5:07 PM
coby updated the diff for D38448: [AsmParser] Support GAS's .print directive.
Sun, Oct 1, 1:28 PM
coby created D38448: [AsmParser] Support GAS's .print directive.
Sun, Oct 1, 1:23 PM
coby updated the diff for D37461: [X86][AsmParser] re-introduce 'offset' operator.

Minimal source changes - introduce 'new' enum calues definitions as adapted on dependent change (D37412)
Added few more assembly level testing, as requested by @rnk
Minimized 'offset_operator.ll' test-case, and auto-updated it checks

Sun, Oct 1, 7:45 AM
coby added inline comments to D37466: D37461: fixups for existing InlineAsm tests + adding new ones.
Sun, Oct 1, 5:45 AM
coby retitled D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob from [x86][inlin-asm] allow recognition of MPX regs inside ms inline-asm blob to [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Sun, Oct 1, 5:15 AM
coby created D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Sun, Oct 1, 5:15 AM

Fri, Sep 29

coby committed rL314529: fixup, post rL314493.
fixup, post rL314493
Fri, Sep 29, 9:06 AM
coby committed rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Fri, Sep 29, 12:04 AM
coby closed D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions by committing rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
Fri, Sep 29, 12:04 AM
coby committed rL314493: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Fri, Sep 29, 12:04 AM
coby closed D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions by committing rL314493: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
Fri, Sep 29, 12:04 AM

Thu, Sep 28

coby committed rL314410: [x86][AsmParser] Allow some more MS size directives.
[x86][AsmParser] Allow some more MS size directives
Thu, Sep 28, 4:08 AM
coby closed D37190: [x86][AsmParser] Allow some more MS size directives by committing rL314410: [x86][AsmParser] Allow some more MS size directives.
Thu, Sep 28, 4:08 AM

Wed, Sep 27

coby committed rL314302: revert rL314300.
revert rL314300
Wed, Sep 27, 6:04 AM
coby added a reverting commit for rL314300: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…: rL314302: revert rL314300.
Wed, Sep 27, 6:04 AM
coby committed rL314300: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Wed, Sep 27, 5:38 AM
coby added a comment to D37801: [x86] fix pr29061.

Fixed in rL314203 @coby Make sure you spell "Differential Revision: " correctly!

Wed, Sep 27, 3:34 AM
coby committed rL314295: [X86][AsmParser] fix PR32035.
[X86][AsmParser] fix PR32035
Wed, Sep 27, 3:31 AM
coby closed D37473: [X86][AsmParser] fix PR32035 by committing rL314295: [X86][AsmParser] fix PR32035.
Wed, Sep 27, 3:31 AM

Tue, Sep 26

coby committed rL314203: [x86] fix pr29061.
[x86] fix pr29061
Tue, Sep 26, 3:33 PM

Mon, Sep 25

coby added a comment to D37945: [X86] [ASM INTEL SYNTAX] fix for incorrect assembler code generation when x86-asm-syntax=intel (PR34617).

suggested change will work fine if one is to solely consider masm / gas, as llvm's (x86) integrated assembler is yet to be introduced to the 'offset' keyword (handle it partially and falsely as part of inline-asm only).
for example, the following (dumb) snippet:

Mon, Sep 25, 12:58 PM
coby added a reviewer for D37945: [X86] [ASM INTEL SYNTAX] fix for incorrect assembler code generation when x86-asm-syntax=intel (PR34617): coby.
Mon, Sep 25, 12:46 PM
coby added a comment to D37473: [X86][AsmParser] fix PR32035.

@coby Are you intending to commit this?

Mon, Sep 25, 5:02 AM

Sep 19 2017

coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

sure, will update shortly

Sep 19 2017, 12:50 AM

Sep 17 2017

coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

addressed @rnk 's suggestions:
cuteness out
c++ mischief in

Sep 17 2017, 12:54 AM
coby added a comment to D37466: D37461: fixups for existing InlineAsm tests + adding new ones.

ping

Sep 17 2017, 12:45 AM
coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

ping

Sep 17 2017, 12:45 AM
coby updated the diff for D37801: [x86] fix pr29061.

addressed Simon's comment

Sep 17 2017, 12:26 AM

Sep 14 2017

coby added inline comments to D37801: [x86] fix pr29061.
Sep 14 2017, 12:07 AM

Sep 13 2017

coby updated the summary of D37801: [x86] fix pr29061.
Sep 13 2017, 5:21 AM
coby created D37801: [x86] fix pr29061.
Sep 13 2017, 5:13 AM

Sep 12 2017

coby added inline comments to D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 12 2017, 11:56 PM
coby added a comment to D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

also, i'll appreciate if you may review/accept the (essential) frontend changes - D37413

Sep 12 2017, 4:29 AM
coby added inline comments to D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 12 2017, 4:24 AM

Sep 11 2017

coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 11 2017, 12:02 AM

Sep 10 2017

coby updated the diff for D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

Addressed Simon's comments

Sep 10 2017, 6:34 AM
coby updated the summary of D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 10 2017, 6:33 AM
coby updated the summary of D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 10 2017, 6:32 AM
coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

addressed Simon's comments

Sep 10 2017, 6:32 AM
coby committed rL312882: [clang][SemaStmtAsm] small refactoring, NFC..
[clang][SemaStmtAsm] small refactoring, NFC.
Sep 10 2017, 5:40 AM
coby committed rL312881: [X86][X86AsmParser] adding const on InlineAsmIdentifierInfo in….
[X86][X86AsmParser] adding const on InlineAsmIdentifierInfo in…
Sep 10 2017, 5:22 AM

Sep 6 2017

coby updated the summary of D37461: [X86][AsmParser] re-introduce 'offset' operator.
Sep 6 2017, 2:47 AM
coby updated the diff for D37473: [X86][AsmParser] fix PR32035.

moved test into intel-syntax-encoding.s

Sep 6 2017, 12:24 AM

Sep 5 2017

coby created D37473: [X86][AsmParser] fix PR32035.
Sep 5 2017, 6:33 AM
coby added a comment to D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021).

might be a bit unrelated - but do we've got a hint regarding why is this even an issue?
by all means - it doesn't seems right for an empty ms inline-asm statement to affect successful compilation, without even mentioning the involvement of the encapsulating function's return type.
Another semi-adopted MS legacy issue?

Sep 5 2017, 4:46 AM
coby created D37466: D37461: fixups for existing InlineAsm tests + adding new ones.
Sep 5 2017, 4:33 AM
coby added inline comments to D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 5 2017, 4:28 AM
coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

Adding @mcrosier , as he originally introduced the feature

Sep 5 2017, 4:10 AM
coby added a reviewer for D37461: [X86][AsmParser] re-introduce 'offset' operator: mcrosier.
Sep 5 2017, 4:08 AM
coby added a dependency for D37461: [X86][AsmParser] re-introduce 'offset' operator: D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 5 2017, 4:03 AM
coby updated the diff for D37461: [X86][AsmParser] re-introduce 'offset' operator.
Sep 5 2017, 4:03 AM
coby added a dependent revision for D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions: D37461: [X86][AsmParser] re-introduce 'offset' operator.
Sep 5 2017, 4:03 AM
coby created D37461: [X86][AsmParser] re-introduce 'offset' operator.
Sep 5 2017, 3:27 AM

Sep 3 2017

coby abandoned D37423: test_2.
Sep 3 2017, 5:52 AM
coby abandoned D37422: test.
Sep 3 2017, 5:51 AM
coby created D37423: test_2.
Sep 3 2017, 5:48 AM
coby added a dependency for D37423: test_2: D37422: test.
Sep 3 2017, 5:48 AM
coby added a dependent revision for D37422: test: D37423: test_2.
Sep 3 2017, 5:48 AM
coby added a dependency for D37422: test: D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 3 2017, 5:44 AM
coby added a dependent revision for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions: D37422: test.
Sep 3 2017, 5:44 AM
coby updated the diff for D37422: test.

test

Sep 3 2017, 5:40 AM
coby created D37422: test.
Sep 3 2017, 5:39 AM
coby abandoned D35775: [x86][inline-asm]Extend support for memory reference expression.

superseded by D37412

Sep 3 2017, 5:13 AM
coby abandoned D35774: [x86][inline-asm]Extend support for memory reference expression.

superseded by D37413

Sep 3 2017, 5:13 AM
coby closed D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax.

superseded by D37412

Sep 3 2017, 5:10 AM

Sep 2 2017

coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 2 2017, 2:31 PM
coby updated the diff for D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 2 2017, 2:28 PM

Sep 1 2017

coby created D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 1 2017, 9:47 PM
coby created D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 1 2017, 9:28 PM

Aug 27 2017

coby created D37190: [x86][AsmParser] Allow some more MS size directives.
Aug 27 2017, 4:50 AM

Aug 24 2017

coby accepted D37110: [X86AsmParser] Refactor AsmRewrite constructors, NFCI.

lgtm

Aug 24 2017, 7:50 AM
coby added a comment to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.

great :)
and thanks again for taking care of my code mischief

Aug 24 2017, 7:34 AM
coby committed rL311657: [fixup][rL311639].
[fixup][rL311639]
Aug 24 2017, 7:12 AM
coby added a comment to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.
AsmRewrite(SMLoc loc, unsigned len, IntelExpr exp) : AsmRewrite(AOK_IntelExpr, loc, len) { IntelExp = exp; }

Same can be done for the 2nd c'tor (& 'label'). Again - it is a style thingy, nothing too cardinal, if you find the current implementation equivalent/better - keep it

Aug 24 2017, 7:01 AM
coby added inline comments to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.
Aug 24 2017, 6:41 AM
coby added inline comments to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.
Aug 24 2017, 6:21 AM
coby added a comment to D37105: [X86AsmParser] Fix msan: use-of-uninitialized-value after r311639.

@krasimir - was on the process of building the sanitizer and validating, you beat me to it

Aug 24 2017, 6:19 AM
coby committed rL311644: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
[LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints
Aug 24 2017, 2:09 AM
coby closed D36369: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints by committing rL311644: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
Aug 24 2017, 2:09 AM
coby committed rL311643: [Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
[Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints
Aug 24 2017, 2:08 AM
coby closed D36371: [Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints by committing rL311643: [Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.
Aug 24 2017, 2:08 AM
coby committed rL311640: Fixups to FE tests affected by D36793.
Fixups to FE tests affected by D36793
Aug 24 2017, 1:48 AM
coby closed D36794: Fixups to FE tests affected by D36793 by committing rL311640: Fixups to FE tests affected by D36793.
Aug 24 2017, 1:48 AM
coby committed rL311639: [X86AsmParser] Refactoring, (almost) NFC..
[X86AsmParser] Refactoring, (almost) NFC.
Aug 24 2017, 1:47 AM
coby closed D36793: [X86AsmParser] Refactoring, (almost) NFC. by committing rL311639: [X86AsmParser] Refactoring, (almost) NFC..
Aug 24 2017, 1:47 AM
coby added inline comments to D36793: [X86AsmParser] Refactoring, (almost) NFC..
Aug 24 2017, 1:25 AM

Aug 23 2017

coby updated the diff for D36793: [X86AsmParser] Refactoring, (almost) NFC..

Addressed @rnk 's comments (thanks!)

Aug 23 2017, 2:53 PM

Aug 21 2017

coby committed rL311309: [X86] Allow xacquire/xrelease prefixes.
[X86] Allow xacquire/xrelease prefixes
Aug 21 2017, 12:51 AM
coby closed D36845: [X86] Allow xacquire/xrelease prefixes by committing rL311309: [X86] Allow xacquire/xrelease prefixes.
Aug 21 2017, 12:51 AM

Aug 20 2017

coby updated the diff for D36371: [Clang][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.

Add forgotten test.

Aug 20 2017, 7:14 AM
coby updated the diff for D36369: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints.

Addreseed @rnk 's comments (thanks) + added some forgotten checks

Aug 20 2017, 7:11 AM
coby updated the diff for D36793: [X86AsmParser] Refactoring, (almost) NFC..

Removed AOK_Delete as it has no use anymore

Aug 20 2017, 6:14 AM
coby added a comment to D35621: X86 Asm can't work properly with symbolic Scale.

+ I'm currently having a patch on review (D36793) which contains most of the intended goals of this one (everything but the new error, afaik), can you verify it answers your needs?

Yes, I see that everything I need here is included in D36793. When are you going to commit it?

as soon as it'll get approved..

Finally, as I understand I should abandom this review because now it's a part of D36793 (including tests, etc.), right?

indeed. note that your added diagnostics are not part of D36793, so consider adding them afterwards if you still fancy it.

Aug 20 2017, 6:10 AM
coby added a comment to D35774: [x86][inline-asm]Extend support for memory reference expression.

This patch is largely covered by D36793, and so better be conducted afterwards.
will upload updated version once D36793 is approved and commited. sorry for all the hassle.

Aug 20 2017, 6:07 AM
coby updated the diff for D36845: [X86] Allow xacquire/xrelease prefixes.

@RKSimon : Please can you add tests for the intel-syntax acquire/release as well?

Aug 20 2017, 5:10 AM

Aug 19 2017

coby added a comment to D36793: [X86AsmParser] Refactoring, (almost) NFC..

IntelExpr::isValid looks rather strange because it validates possible multiplication only. But if we have Scale == 1 and don't have either BaseReg or Disp?

Aug 19 2017, 3:08 PM