coby (coby)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2016, 7:41 AM (65 w, 4 d)

Recent Activity

Sun, Nov 26

coby committed rL318993: [x86][icelake]GFNI.
[x86][icelake]GFNI
Sun, Nov 26, 1:38 AM
coby closed D40373: [x86][icelake]GFNI by committing rL318993: [x86][icelake]GFNI.
Sun, Nov 26, 1:37 AM

Sat, Nov 25

coby updated the diff for D40373: [x86][icelake]GFNI.

addressed Craig's comments

Sat, Nov 25, 5:42 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Sat, Nov 25, 1:57 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Sat, Nov 25, 1:54 PM

Thu, Nov 23

coby committed rL318904: [x86][icelake]BITALG.
[x86][icelake]BITALG
Thu, Nov 23, 3:16 AM
coby closed D40222: [x86][icelake]BITALG by committing rL318904: [x86][icelake]BITALG.
Thu, Nov 23, 3:16 AM
coby updated the diff for D40373: [x86][icelake]GFNI.

adopted changes proposed by Craig:
maskz variants are out in favor of explicit passing of the additive identity
BWI dependency is explicitly stated
GCC builtins counterparts are matched

Thu, Nov 23, 1:55 AM

Wed, Nov 22

coby added inline comments to D40373: [x86][icelake]GFNI.
Wed, Nov 22, 12:41 PM
coby updated the diff for D40222: [x86][icelake]BITALG.

adopted a stricter type constraints on bits shuffle node, as suggested by Craig

Wed, Nov 22, 12:31 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Wed, Nov 22, 12:29 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Wed, Nov 22, 12:26 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Wed, Nov 22, 12:14 PM
coby added inline comments to D40373: [x86][icelake]GFNI.
Wed, Nov 22, 12:11 PM
coby updated the summary of D40373: [x86][icelake]GFNI.
Wed, Nov 22, 11:43 AM
coby created D40373: [x86][icelake]GFNI.
Wed, Nov 22, 11:40 AM

Tue, Nov 21

coby updated the diff for D40222: [x86][icelake]BITALG.

intrinsics support (3/3)

Tue, Nov 21, 3:39 AM
coby committed rL318748: [x86][icelake]BITALG.
[x86][icelake]BITALG
Tue, Nov 21, 2:33 AM
coby closed D40213: [x86][icelake]BITALG by committing rL318748: [x86][icelake]BITALG.
Tue, Nov 21, 2:32 AM
coby committed rL318746: [x86][icelake]VNNI.
[x86][icelake]VNNI
Tue, Nov 21, 2:07 AM
coby closed D40208: [x86][icelake]VNNI by committing rL318746: [x86][icelake]VNNI.
Tue, Nov 21, 2:07 AM
coby committed rL318745: [x86][icelake]vbmi2.
[x86][icelake]vbmi2
Tue, Nov 21, 1:49 AM
coby closed D40206: [x86][icelake]vbmi2 by committing rL318745: [x86][icelake]vbmi2.
Tue, Nov 21, 1:49 AM
coby committed rL318741: [x86][icelake]vpclmulqdq introduction.
[x86][icelake]vpclmulqdq introduction
Tue, Nov 21, 1:31 AM
coby closed D40101: [x86][icelake]vpclmulqdq introduction by committing rL318741: [x86][icelake]vpclmulqdq introduction.
Tue, Nov 21, 1:30 AM
coby committed rL318740: [x86][icelake]VAES introduction.
[x86][icelake]VAES introduction
Tue, Nov 21, 1:12 AM
coby closed D40078: [x86][icelake]VAES introduction by committing rL318740: [x86][icelake]VAES introduction.
Tue, Nov 21, 1:11 AM
coby committed rL318739: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
[x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob
Tue, Nov 21, 12:51 AM
coby closed D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob by committing rL318739: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Tue, Nov 21, 12:51 AM

Mon, Nov 20

coby updated the diff for D40213: [x86][icelake]BITALG.

added tzcnt tests
removed redundant blank line

Mon, Nov 20, 6:38 AM
coby updated the diff for D40078: [x86][icelake]VAES introduction.

further refined selection of conflicting insns, as suggested by Craig (thanks)

Mon, Nov 20, 5:28 AM
coby added a comment to D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.

Reid,
can you please have a look?

Mon, Nov 20, 5:12 AM
coby updated the diff for D40078: [x86][icelake]VAES introduction.
Mon, Nov 20, 5:06 AM
coby updated the diff for D40101: [x86][icelake]vpclmulqdq introduction.

further refined selection of conflicting insns, as suggested by Craig
added commutation tests, as suggested by Simon

Mon, Nov 20, 4:35 AM
coby updated the diff for D40206: [x86][icelake]vbmi2.

Separated VBMI2's concatenate/shift insns implementation course from PMADD52

Mon, Nov 20, 12:42 AM

Sun, Nov 19

coby added a dependent revision for D40213: [x86][icelake]BITALG: D40222: [x86][icelake]BITALG.
Sun, Nov 19, 1:06 AM
coby added a dependency for D40222: [x86][icelake]BITALG: D40213: [x86][icelake]BITALG.
Sun, Nov 19, 1:06 AM
coby created D40222: [x86][icelake]BITALG.
Sun, Nov 19, 1:05 AM

Sat, Nov 18

coby created D40213: [x86][icelake]BITALG.
Sat, Nov 18, 1:23 PM
coby created D40208: [x86][icelake]VNNI.
Sat, Nov 18, 6:08 AM

Fri, Nov 17

coby added reviewers for D40206: [x86][icelake]vbmi2: craig.topper, igorb.
Fri, Nov 17, 10:14 PM
coby created D40206: [x86][icelake]vbmi2.
Fri, Nov 17, 10:13 PM

Wed, Nov 15

coby updated the diff for D40101: [x86][icelake]vpclmulqdq introduction.

refined VPCLMULQDQ recognition in favor of PCLMULQDQ

Wed, Nov 15, 3:31 PM
coby created D40101: [x86][icelake]vpclmulqdq introduction.
Wed, Nov 15, 2:33 PM
coby added inline comments to D40078: [x86][icelake]VAES introduction.
Wed, Nov 15, 1:29 PM
coby updated the diff for D40078: [x86][icelake]VAES introduction.

addressed Craig's comments

Wed, Nov 15, 12:33 PM
coby added inline comments to D40078: [x86][icelake]VAES introduction.
Wed, Nov 15, 11:48 AM
coby added inline comments to D40078: [x86][icelake]VAES introduction.
Wed, Nov 15, 11:33 AM
coby added a comment to D40078: [x86][icelake]VAES introduction.

intel syntax encoding test is to be added shortly

Wed, Nov 15, 7:30 AM
coby created D40078: [x86][icelake]VAES introduction.
Wed, Nov 15, 7:29 AM

Nov 2 2017

coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

@coby What is happening with this patch?

Nov 2 2017, 3:43 AM

Oct 2 2017

coby committed rL314674: [AsmParser] Support GAS's .print directive.
[AsmParser] Support GAS's .print directive
Oct 2 2017, 7:38 AM
coby closed D38448: [AsmParser] Support GAS's .print directive by committing rL314674: [AsmParser] Support GAS's .print directive.
Oct 2 2017, 7:38 AM
coby added a comment to D38448: [AsmParser] Support GAS's .print directive.

thanks for the prompt review.
will address enum's values definition ordering upon the commit itself

Oct 2 2017, 6:44 AM

Oct 1 2017

coby added inline comments to D38448: [AsmParser] Support GAS's .print directive.
Oct 1 2017, 5:07 PM
coby updated the diff for D38448: [AsmParser] Support GAS's .print directive.
Oct 1 2017, 1:28 PM
coby created D38448: [AsmParser] Support GAS's .print directive.
Oct 1 2017, 1:23 PM
coby updated the diff for D37461: [X86][AsmParser] re-introduce 'offset' operator.

Minimal source changes - introduced 'new' enum values definitions as adapted on dependent change (D37412)
Added few more assembly level testing, as requested by @rnk
Minimized 'offset_operator.ll' test-case, and auto-updated it checks

Oct 1 2017, 7:45 AM
coby added inline comments to D37466: D37461: fixups for existing InlineAsm tests + adding new ones.
Oct 1 2017, 5:45 AM
coby retitled D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob from [x86][inlin-asm] allow recognition of MPX regs inside ms inline-asm blob to [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Oct 1 2017, 5:15 AM
coby created D38445: [x86][inline-asm] allow recognition of MPX regs inside ms inline-asm blob.
Oct 1 2017, 5:15 AM

Sep 29 2017

coby committed rL314529: fixup, post rL314493.
fixup, post rL314493
Sep 29 2017, 9:06 AM
coby committed rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Sep 29 2017, 12:04 AM
coby closed D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions by committing rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
Sep 29 2017, 12:04 AM
coby committed rL314493: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Sep 29 2017, 12:04 AM
coby closed D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions by committing rL314493: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
Sep 29 2017, 12:04 AM

Sep 28 2017

coby committed rL314410: [x86][AsmParser] Allow some more MS size directives.
[x86][AsmParser] Allow some more MS size directives
Sep 28 2017, 4:08 AM
coby closed D37190: [x86][AsmParser] Allow some more MS size directives by committing rL314410: [x86][AsmParser] Allow some more MS size directives.
Sep 28 2017, 4:08 AM

Sep 27 2017

coby committed rL314302: revert rL314300.
revert rL314300
Sep 27 2017, 6:04 AM
coby added a reverting commit for rL314300: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…: rL314302: revert rL314300.
Sep 27 2017, 6:04 AM
coby committed rL314300: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /….
[X86][MS-InlineAsm] Extended support for variables / identifiers on memory /…
Sep 27 2017, 5:38 AM
coby added a comment to D37801: [x86] fix pr29061.

Fixed in rL314203 @coby Make sure you spell "Differential Revision: " correctly!

Sep 27 2017, 3:34 AM
coby committed rL314295: [X86][AsmParser] fix PR32035.
[X86][AsmParser] fix PR32035
Sep 27 2017, 3:31 AM
coby closed D37473: [X86][AsmParser] fix PR32035 by committing rL314295: [X86][AsmParser] fix PR32035.
Sep 27 2017, 3:31 AM

Sep 26 2017

coby committed rL314203: [x86] fix pr29061.
[x86] fix pr29061
Sep 26 2017, 3:33 PM

Sep 25 2017

coby added a comment to D37945: [X86] [ASM INTEL SYNTAX] fix for incorrect assembler code generation when x86-asm-syntax=intel (PR34617).

suggested change will work fine if one is to solely consider masm / gas, as llvm's (x86) integrated assembler is yet to be introduced to the 'offset' keyword (handle it partially and falsely as part of inline-asm only).
for example, the following (dumb) snippet:

Sep 25 2017, 12:58 PM
coby added a reviewer for D37945: [X86] [ASM INTEL SYNTAX] fix for incorrect assembler code generation when x86-asm-syntax=intel (PR34617): coby.
Sep 25 2017, 12:46 PM
coby added a comment to D37473: [X86][AsmParser] fix PR32035.

@coby Are you intending to commit this?

Sep 25 2017, 5:02 AM

Sep 19 2017

coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

sure, will update shortly

Sep 19 2017, 12:50 AM

Sep 17 2017

coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

addressed @rnk 's suggestions:
cuteness out
c++ mischief in

Sep 17 2017, 12:54 AM
coby added a comment to D37466: D37461: fixups for existing InlineAsm tests + adding new ones.

ping

Sep 17 2017, 12:45 AM
coby added a comment to D37461: [X86][AsmParser] re-introduce 'offset' operator.

ping

Sep 17 2017, 12:45 AM
coby updated the diff for D37801: [x86] fix pr29061.

addressed Simon's comment

Sep 17 2017, 12:26 AM

Sep 14 2017

coby added inline comments to D37801: [x86] fix pr29061.
Sep 14 2017, 12:07 AM

Sep 13 2017

coby updated the summary of D37801: [x86] fix pr29061.
Sep 13 2017, 5:21 AM
coby created D37801: [x86] fix pr29061.
Sep 13 2017, 5:13 AM

Sep 12 2017

coby added inline comments to D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 12 2017, 11:56 PM
coby added a comment to D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

also, i'll appreciate if you may review/accept the (essential) frontend changes - D37413

Sep 12 2017, 4:29 AM
coby added inline comments to D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 12 2017, 4:24 AM

Sep 11 2017

coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 11 2017, 12:02 AM

Sep 10 2017

coby updated the diff for D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

Addressed Simon's comments

Sep 10 2017, 6:34 AM
coby updated the summary of D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 10 2017, 6:33 AM
coby updated the summary of D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.
Sep 10 2017, 6:32 AM
coby updated the diff for D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions.

addressed Simon's comments

Sep 10 2017, 6:32 AM
coby committed rL312882: [clang][SemaStmtAsm] small refactoring, NFC..
[clang][SemaStmtAsm] small refactoring, NFC.
Sep 10 2017, 5:40 AM
coby committed rL312881: [X86][X86AsmParser] adding const on InlineAsmIdentifierInfo in….
[X86][X86AsmParser] adding const on InlineAsmIdentifierInfo in…
Sep 10 2017, 5:22 AM

Sep 6 2017

coby updated the summary of D37461: [X86][AsmParser] re-introduce 'offset' operator.
Sep 6 2017, 2:47 AM
coby updated the diff for D37473: [X86][AsmParser] fix PR32035.

moved test into intel-syntax-encoding.s

Sep 6 2017, 12:24 AM

Sep 5 2017

coby created D37473: [X86][AsmParser] fix PR32035.
Sep 5 2017, 6:33 AM
coby added a comment to D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021).

might be a bit unrelated - but do we've got a hint regarding why is this even an issue?
by all means - it doesn't seems right for an empty ms inline-asm statement to affect successful compilation, without even mentioning the involvement of the encapsulating function's return type.
Another semi-adopted MS legacy issue?

Sep 5 2017, 4:46 AM